- Feb 26, 2016
-
-
Amitoj Kaur Chawla authored
Unnecessary dev_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @@ struct device *dev; @@ - dev_set_drvdata(dev, NULL); //</smpl> Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
David Kershner authored
The pfn field in the channel is 64 bits, the parameter being passed should be 64 bits as well. Signed-off-by:
David Kershner <david.kershner@unisys.com> Signed-off-by:
-
David Kershner authored
Smatch complained about inconsistent indenting. This patch addresses it. Signed-off-by:
-
Benjamin Romer authored
The other error paths return meaningful error codes, except for the one when registering a device, which just returned -1. Let's return ENODEV when it fails to register instead. Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Benjamin Romer authored
Simplify this function by removing the goto in favor of handling errors immediately. Eliminate the vaguely-named variable x, and remove the unneeded initialization of rc. Lastly, provide meaningful error values to the callback function instead of just passing back a -1 for failure. Signed-off-by:
-
Benjamin Romer authored
The value of rc is set by calling a function, so there's no need to initialize it to -1, or anything at all. Signed-off-by:
-
Benjamin Romer authored
Remove the unnecessary rc and goto messiness, and just handle freeing the memory before returning an error in the one place where that needs to happen. Signed-off-by:
-
Benjamin Romer authored
Get rid of the rc = -1 initialization. Return a meaningful error on failure in the function, or, the rc from a called function if it fails. Signed-off-by:
-
Benjamin Romer authored
Remove the rc, the = -1, and all the goto mess here and just return directly with a meaningful error number. The caller only cares about success/failure right now, that needs to be addressed in a later patch series. Signed-off-by:
-
Benjamin Romer authored
Instead of returning -1, return -ENODEV when there is no probe function found for the device. Signed-off-by:
-
Aaro Koskinen authored
Update TODO. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Avoid an overlong line. Signed-off-by:
-
Aaro Koskinen authored
Move next pipe selection into a separate function to avoid deep nesting. Signed-off-by:
-
Aaro Koskinen authored
Move isochronous transfer handling into a separate function to avoid deep indentation. Signed-off-by:
-
Aaro Koskinen authored
Move bulk transfer handling into a separate function to avoid deep indentation. Signed-off-by:
-
Aaro Koskinen authored
Move bulk transfer handling into a separate function to avoid deep indentation. Signed-off-by:
-
Aaro Koskinen authored
Move control transfer handling into a separate function to avoid deep indentation. Signed-off-by:
-
Aaro Koskinen authored
Fold cvmx_usb_state into octeon_hcd. Signed-off-by:
-
Aaro Koskinen authored
Rename STATUS_SUCCESS to STATUS_OK. Signed-off-by:
-
Aaro Koskinen authored
Rename cvmx_usb_perform_complete to cvmx_usb_complete. Signed-off-by:
-
Aaro Koskinen authored
Rename cvmx_usb_complete to cvmx_usb_status. Signed-off-by:
-
Aaro Koskinen authored
Simplify if statement to avoid deep nesting. Signed-off-by:
-
Aaro Koskinen authored
Since we always search the same list, we can just pass the transfer type. Signed-off-by:
-
Aaro Koskinen authored
current_frame always equals usb->frame_number. Signed-off-by:
-
Aaro Koskinen authored
Align split lines to match open parenthesis. Signed-off-by:
-
Aaro Koskinen authored
Use preferred coding style for NULL comparison. Signed-off-by:
-
Bhaktipriya Shridhar authored
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)). It clarifies the divisor calculations. This occurence was detected using the coccinelle script: @@ expression e1; expression e2; @@ ( - ((e1) + e2 - 1) / (e2) + DIV_ROUND_UP(e1,e2) | - ((e1) + (e2 - 1))/ (e2) + DIV_ROUND_UP(e1,e2) ) The macro CEILING was dropped altogether and has been replaced with DIV_ROUND_UP. Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Do not print message if kzalloc() failed. kzalloc() has its own messages. So no need to add extra one. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Eliminate local variable 'ret' and modify return statement to contain the value being returned directly instead of assigning it first to 'ret' and returning this variable. Coccinelle semantic patch used: @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Alison Schofield authored
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch renames u16reason to reason to remove u16 prefix. There is no need to use prefix to show data type. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch renames struct tstrDisconnectNotifInfo to disconnect_info to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames u16ConnectStatus to status to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames u16RespIEsLen to resp_ies_len to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames pu8RespIEs to resp_ies to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames ReqIEsLen to req_ies_len to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames pu8ReqIEs to req_ies to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames au8bssid to bssid to remove au8 prefix in struct connect_info. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Chaehyun Lim authored
This patch renames struct tstrConnectInfo to connect_info to avoid camelcase and removes typedef. Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by:
-
