- Jan 18, 2015
-
-
Jonathan Jin authored
Fix a checkpatch.pl warning regarding quoted string splits across lines. While each join of these quoted strings results in a new checkpatch.pl "lines over 80 characters" warning, the regained ability to grep for these log strings in the codebase is, I would argue, well worth the trade-off. Signed-off-by:
Jonathan Jin <jjin082693@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Gangadhar Vukkesala authored
Fixed a space coding style issue which was found when running checkpatch.pl script on rtw_ap.c. Signed-off-by:
Gangadhar Vukkesala <gangs.freelancer@gmail.com> Reviewed-by:
Jeremiah Mahler <jmmahler@gmail.com> Signed-off-by:
-
Abel Moyo authored
Removed inline function get_my_bssid and open coded all its references Signed-off-by:
Abel Moyo <abelmoyo.ab@gmail.com> Signed-off-by:
-
Alexey Tulia authored
drivers/staging/rtl8723au/core/rtw_xmit.c:2375 warning: symbol 'rtw_ack_tx_done23a' was not declared. Should it be static? Function 'rtw_ack_tx_done23a' seems to be unused in current staging code. Signed-off-by:
Alexey Tulia <alexey.tulia@gmail.com> Signed-off-by:
-
Rickard Strandqvist authored
Removes some functions that are not used anywhere: odm_1R_CCA23a() odm_TXPowerTrackingCheckAP() odm_TXPowerTrackingCheckMP() odm_RSSIMonitorCheck23aAP() odm_RSSIMonitorCheck23aMP() odm_RSSIMonitorInit() odm_RefreshRateAdaptiveMask23aAPADSL23a() odm_RefreshRateAdaptiveMask23aMP23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:
-
Joe Borg authored
Fixing styling errors found with checkpatch.pl. These include: "(foo*)" should be "(foo *)" space required after that ';' ...totalling 5 styling errors. Signed-off-by:
Joe Borg <joe@josephb.org> Signed-off-by:
-
Yannis Damigos authored
This is a patch to the hal/rtl8723au_xmit.c file that fixes the following warnings found by sparse tool: drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: expected unsigned int [usertype] *pdw drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: got restricted __le32 *<noident> drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: expected unsigned int [usertype] *pdw drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: got restricted __le32 *<noident> Signed-off-by:
Yannis Damigos <giannis.damigos@gmail.com> Signed-off-by:
-
Asaf Vertz authored
Fixed a coding style error, "foo * bar" should be "foo *bar" Signed-off-by:
Asaf Vertz <asaf.vertz@tandemg.com> Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Krzysztof Konopko authored
Some struct fields in wifi.h are meant to be __le16 but were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16 rtw_wlan_util.c:1544:29: warning: cast to restricted __le16 rtw_wlan_util.c:1546:25: warning: cast to restricted __le16 This patch updates the types of the fields in `AC_param` and `ADDBA_request` structs to be consistent with relevant structs in include/linux/ieee80211.h. Signed-off-by:
Krzysztof Konopko <kris@konagma.com> Signed-off-by:
-
Dean Michael Ancajas authored
Fixed a coding style issue for braces. Signed-off-by:
Dean Michael Ancajas <dbancajas@gmail.com> Signed-off-by:
-
Anjana Sasindran authored
This patch fix the checkpatch.pl warning: WARNING: space before semicolon prohibited Signed-off-by:
Anjana Sasindran <anjanasasindran123@gmail.com> Signed-off-by:
-
Anjana Sasindran authored
This patch fix the checkpatch.pl warning: WARNING: spaces prohibited before semicolon Signed-off-by:
-
Anjana Sasindran authored
This patch fix the checkpatch.pl warning: WARNING: Missing blank line after declaration Signed-off-by:
-
Greg Donald authored
Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors Signed-off-by:
Greg Donald <gdonald@gmail.com> Signed-off-by:
-
Jes Sorensen authored
This is a no-op change, but it improves consistency. Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Use the correct register names when setting parameters to reduce 80M spur. In addition apply updated 80M spur reduction parameters. Original patch supplied by Andrew Chang <andrew.chang@realtek.com> Signed-off-by:
-
Jes Sorensen authored
struct usb_host_interface points to an array of struct usb_host_endpoints - it makes no sense to do a NULL pointer check for each pointer. Signed-off-by:
-
- Jan 13, 2015
-
-
Anjana Sasindran authored
This patch fix the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by:
-
Paul Hedman authored
This patch fixes a brace warning in rtl871x_sta_mgt.c found by the checkpatch.pl tool. Signed-off-by:
Paul Hedman <paul@mybb.com> Signed-off-by:
-
Emrys Bayliss authored
This patch fixes the following checkpatch.pl error: rxtx.c:588: WARNING: else is not generally useful after a break or return Signed-off-by:
Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by:
-
Gustavo A. R. Silva authored
Fixed typo in a variable name in dpc.h file. Signed-off-by:
Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by:
-
Gustavo A. R. Silva authored
Fixed typo in a macro name in card.c and device.h files. Signed-off-by:
-
Gustavo A. R. Silva authored
Fixed a typo in mac.c file. Signed-off-by:
-
Malcolm Priestley authored
The device must not flip to page 1 while in interrupt lock causing loss of connection or dead lock. Protect from changes to page by adding lock where user can change the page in CARDvSetRSPINF, vnt_configure and set_channel Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Piotr Kubus authored
Fixed a space coding style issue found by checkpatch.pl in rxtx.c. Signed-off-by:
Piotr Kubus <p.t.kubus@gmail.com> Signed-off-by:
-
Sakshi Bansal authored
Signed-off-by:
Sakshi Bansal <sakshi.april5@gmail.com> Signed-off-by:
-
Nicholas Parkanyi authored
This patch fixes the following checkpatch.pl warnings: ERROR: do not use C99 // comments +// ERROR: do not use C99 // comments +// For memory mapped IO ERROR: do not use C99 // comments +// ERROR: do not use C99 // comments +#endif // __UPC_H__ ERROR: do not use C99 // comments + // set period of power up before TBTT ERROR: do not use C99 // comments + // set AID ERROR: do not use C99 // comments + // set ATIM Window ERROR: do not use C99 // comments + // Set AutoSleep ERROR: do not use C99 // comments + // Set HWUTSF ERROR: do not use C99 // comments + // clear always listen beacon ERROR: do not use C99 // comments + // first time set listen next beacon ERROR: do not use C99 // comments + // always listen beacon ERROR: do not use C99 // comments + // enable power saving hw function ERROR: do not use C99 // comments + // disable power saving hw function ERROR: do not use C99 // comments + //clear AutoSleep ERROR: do not use C99 // comments + //clear HWUTSF ERROR: do not use C99 // comments + // set always listen beacon Signed-off-by:
Nicholas Parkanyi <n.parkanyi@gmail.com> Signed-off-by:
-
Krzysztof Adamski authored
This fixes following checkpatch.pl error: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by:
Krzysztof Adamski <k@japko.eu> Signed-off-by:
-
Fred Chou authored
Removed the unused function MACvGetShortRetryLimit, which also fixed the following sparse warning: drivers/staging/vt6655/mac.c:162:6: warning: symbol 'MACvGetShortRetryLimit' was not declared. Should it be static? Signed-off-by:
Fred Chou <fred.chou.nd@gmail.com> Signed-off-by:
-
Krzysztof Adamski authored
This patch fixes checkpatch.pl warning: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) current_net_addr and permanent_net_addr members of vnt_private alignment is changed to at last 16 bits so that ether_addr_copy can be safely used on them. buf->data is of type ieee80211_cts which is already properly aligned. Signed-off-by:
-
Krzysztof Adamski authored
Both struct ieee80211_rts and struct ieee80211_hdr defined in linux/ieee80211.h are declared as __aligned(2) so it is safe to use ether_addr_copy() instead of memcpy(). Signed-off-by:
-
