- Jul 12, 2018
-
-
Al Viro authored
Acked-by:
Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
-
Al Viro authored
Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
alloc_file_clone(old_file, mode, ops): create a new struct file with ->f_path equal to that of old_file. pipe converted. Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
grab inode and reserve memory first. Acked-by:
-
Al Viro authored
takes inode, vfsmount, name, O_... flags and file_operations and either returns a new struct file (in which case inode reference we held is consumed) or returns ERR_PTR(), in which case no refcounts are altered. converted aio_private_file() and sock_alloc_file() to it Acked-by:
-
Al Viro authored
no users left Acked-by:
-
Al Viro authored
caller can tell "opened" from "open it yourself" by looking at ->f_mode. Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
FMODE_OPENED can be used to distingusish "successful open" from the "called finish_no_open(), do it yourself" cases. Since finish_no_open() has been adjusted, no changes in the instances were actually needed. The caller has been adjusted. Acked-by:
-
Al Viro authored
unused now Acked-by:
-
Al Viro authored
now it can be done... Acked-by:
-
Al Viro authored
__gfs2_lookup(), gfs2_create_inode(), nfs_finish_open() and fuse_create_open() don't need 'opened' anymore. Get rid of that argument in those. Acked-by:
-
Al Viro authored
'opened' argument of finish_open() is unused. Kill it. Signed-off-by Al Viro <viro@zeniv.linux.org.uk>
-
Al Viro authored
just check ->f_mode in ima_appraise_measurement() Acked-by:
-
Al Viro authored
Parallel to FILE_CREATED, goes into ->f_mode instead of *opened. NFS is a bit of a wart here - it doesn't have file at the point where FILE_CREATED used to be set, so we need to propagate it there (for now). IMA is another one (here and everywhere)... Note that this needs do_dentry_open() to leave old bits in ->f_mode alone - we want it to preserve FMODE_CREATED if it had been already set (no other bit can be there). Acked-by:
-
Al Viro authored
... and don't bother with setting FILE_OPENED at all. Acked-by:
-
Al Viro authored
These checks are better off in do_dentry_open(); the reason we couldn't put them there used to be that callers couldn't tell what kind of cleanup would do_dentry_open() failure call for. Now that we have FMODE_OPENED, cleanup is the same in all cases - it's simply fput(). So let's fold that into do_dentry_open(), as Christoph's patch tried to. Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
Just check FMODE_OPENED in __fput() and be done with that... Acked-by:
-
Al Viro authored
basically, "is that instance set up enough for regular fput(), or do we want put_filp() for that one". NOTE: the only alloc_file() caller that could be followed by put_filp() is in arch/ia64/kernel/perfmon.c, which is (Kconfig-level) broken. Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
Acked-by:
-
Al Viro authored
always equal to ->f_cred Acked-by:
-
Al Viro authored
... and have it set the f_flags-derived part of ->f_mode. Signed-off-by: -
Al Viro authored
... and rename get_empty_filp() to alloc_empty_file(). dentry_open() gets creds as argument, but the only thing that sees those is security_file_open() - file->f_cred still ends up with current_cred(). For almost all callers it's the same thing, but there are several broken cases. Acked-by:
-
Al Viro authored
... so that it could set both ->f_flags and ->f_mode, without callers having to set ->f_flags manually. Signed-off-by:
-
- Jul 11, 2018
-
-
Al Viro authored
An ->open() instances really, really should not be doing that. There's a lot of places e.g. around atomic_open() that could be confused by that, so let's catch that early. Acked-by:
-
Al Viro authored
... just use put_pipe_info() to get the pipe->files down to 1 and let fput()-called pipe_release() do freeing. Acked-by:
-
Al Viro authored
it's exactly the same thing as dentry_open(&file->f_path, file->f_flags, file->f_cred) ... and rename it to file_clone_open(), while we are at it. 'filp' naming convention is bogus; sure, it's "file pointer", but we generally don't do that kind of Hungarian notation. Some of the instances have too many callers to touch, but this one has only two, so let's sanitize it while we can... Acked-by:
-
Al Viro authored
.. and the call of file_free() in case of security_file_alloc() failure in get_empty_filp() should be simply file_free_rcu() - no point in rcu-delays there, anyway. Acked-by:
-
Al Viro authored
Cc: stable@vger.kernel.org Acked-by:
-
Al Viro authored
Doing iput() after path_put() is wrong. Cc: stable@vger.kernel.org Acked-by:
-
Al Viro authored
Failure of ->open() should *not* be followed by fput(). Fixed by using filp_clone_open(), which gets the cleanups right. Cc: stable@vger.kernel.org Acked-by:
-
