- Mar 08, 2014
-
-
Tugce Sirin authored
This patch fixes following Sparse warning should it be static? in staging/wlan-ng. Signed-off-by:
Tugce Sirin <ztugcesirin@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Monam Agarwal authored
This patch removes an unused struct while at the same time removing checkpatch.pl warning WARNING: Avoid use of typedef Signed-off-by:
Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by:
-
Monam Agarwal authored
This patch fixes the following checkpatch.pl issues in ced_ioctl.h WARNING: do not add new typedefs Signed-off-by:
-
Monam Agarwal authored
This patch fixes the following checkpatch.pl issues in io.c WARNING: Bad function definition Signed-off-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
Monam Agarwal authored
This patch fixes following checkpatch.pl warning: WARNING:struct file_operations should normally be const Signed-off-by:
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_resp_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/ctrl.h:123: WARNING: do not add new typedefs Signed-off-by:
Kristina Martšenko <kristina.martsenko@gmail.com> Signed-off-by:
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_stats_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/ctrl.h:107: WARNING: do not add new typedefs Signed-off-by:
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_param_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/ctrl.h:87: WARNING: do not add new typedefs Signed-off-by:
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_tx_desc_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/2t3e3.h:651: WARNING: do not add new typedefs Signed-off-by:
-
Kristina Martšenko authored
Kernel coding style does not recommend using typedefs for structures, so remove the t3e3_rx_desc_t typedef. Fix the following checkpatch warning: drivers/staging/sbe-2t3e3/2t3e3.h:616: WARNING: do not add new typedefs Signed-off-by:
-
Elena Oat authored
This patch fixes an error in 2t3e3.h that (foo*) should be (foo *). Signed-off-by:
Elena Oat <oat.elena@gmail.com> Acked-by:
-
Himangi Saraogi authored
This patch removes the assignment in an if condition to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
-
Himangi Saraogi authored
This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by:
-
Himangi Saraogi authored
This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by:
-
Ebru Akagunduz authored
This patch fixes following sparse warning in dgap.c drivers/staging/media/lirc/lirc_sasem.c:392:32: warning: incorrect type in argument 1 (different address spaces) drivers/staging/media/lirc/lirc_sasem.c:392:32: expected void const [noderef] <asn:1>*<noident> drivers/staging/media/lirc/lirc_sasem.c:392:32: got char const *buf drivers/staging/media/lirc/lirc_sasem.c:123:28: warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) drivers/staging/media/lirc/lirc_sasem.c:123:28: expected int ( *write )( ... ) drivers/staging/media/lirc/lirc_sasem.c:123:28: got int ( static [toplevel] *<noident> )( ... ) Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by:
-
Ebru Akagunduz authored
This patch fixes the Sparse Warnings "symbol was not declared. Should it be static?" Signed-off-by:
-
Monam Agarwal authored
This patch fixes the following checkpatch.pl issues in cxd2099.c WARNING: line length over 80 characters Signed-off-by:
-
Himangi Saraogi authored
This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by:
-
- Mar 07, 2014
-
-
Himangi Saraogi authored
This patch fixes the following sparse warning : drivers/staging/lustre/lustre/lmv/lproc_lmv.c:99:35: warning: incorrect type in argument 2 (different address spaces) drivers/staging/lustre/lustre/lmv/lproc_lmv.c:99:35: expected void const [noderef] <asn:1>*from drivers/staging/lustre/lustre/lmv/lproc_lmv.c:99:35: got char const *buffer Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/lustre/lustre/lov/lov_obd.c:342:48: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/lov/lov_obd.c:647:44: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/lov/lov_obd.c:771:46: warning: Using plain integer as NULL pointer Signed-off-by:
-
Himangi Saraogi authored
This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by:
-
Monam Agarwal authored
This patch fixes the following checkpatch.pl issues in lov_ea.c Warning: Statements terminations use 1 semicolon in lov_ea.c Signed-off-by:
-
John de la Garza authored
Added code to check return value of sscanf. Signed-off-by:
John de la Garza <john@jjdev.com> Signed-off-by:
-
John de la Garza authored
Removed unnecessary space before function pointer arguments. Signed-off-by:
-
H Hartley Sweeten authored
Like done in the pcl812 driver, use the boardinfo to determine what should be reset. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
Instead of using the 'board_type' and the switch, use the boardinfo to determine what should be reset. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, rename the timer/counter enable request register and define its bits. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, rename the clear INT request register. Signed-off-by:
-
H Hartley Sweeten authored
The PCL812_CNTENABLE define is not used in this driver. Remove it. For aesthetics, rename the software trigger register. Signed-off-by:
-
H Hartley Sweeten authored
Rename this function so it has namespace associated with the driver. The cmd->scan_begin_src is always TRIG_FOLLOW and the only valid cmd->convert_src is TRIG_TIMER or TRIG_EXT so pcl818_ai_cmd_mode() is always called with a 'mode' of 1 or 3. The 'mode' actually indicates the trigger source. Absorb pcl818_ai_cmd_mode() into this function and simplify the code. This also removes the need for a forward declaration. Signed-off-by:
-
H Hartley Sweeten authored
Absorb this function into pcl818_ai_cmd_mode() and simplify the code. Signed-off-by:
-
H Hartley Sweeten authored
Define the bits in the register to remove the magic values. Tidy up pcl818_ai_cancel(). The 0x73 mask of the value read from the control register will disable dma and interrupts but it does not change the trigger mode. So the software trigger following it might not work. Just disable the trigger and clear any pending end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Define the bits in the register to remove the magic values. Fix pcl816_ai_cancel(). The 0x73 mask of the value read from the control register will not stop the A/D as indicated by the comment. This would just clear the DS1, POE, and EXT bits which would only disable the external trigger. Setting the control register to '0' would then stop the A/D which means the software trigger following it would not work. Just disable the trigger and clear any pending end-of-conversion. Make sure the A/D trigger is disabled at the end of the (*insn_read). Remove a couple unnecessary devpriv->dev checks. The pcl816_ai_cmd() and pcl816_ai_poll() functions are only hooked up when devpriv->dma is valid. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, rename this register. Define the bits in the register to remove the magic values. Signed-off-by:
-
H Hartley Sweeten authored
Move this function to remove the need for the forward declaration. Rename it so it has namespace associated with the driver. Remove the unnecessary comedi_subdevice parameter from the function. The hardware has per-channel programmable gain. This function first sets the range for each channel then sets the mux register to automatically scan the channels. The use of 'muxonechan' when programming the ranges is incorrect. Only the low 4-bits are supposed to be set when programming the ranges. Introduce a couple helper functions to set the range for a channel and to set the first/last channels to scan. Tidy up the range and mux register defines. Signed-off-by:
-
H Hartley Sweeten authored
Move this function to remove the need for the forward declaration. Rename it so it has namespace associated with the driver. Remove the unnecessary comedi_subdevice parameter from the function. The hardware has per-channel programmable gain. This function first sets the range for each channel then sets the mux register to automatically scan the channels. Remove the need for the 'ai_act_chanlist' member in the private data. It is only used to set the first/last channel to scan. Introduce a couple helper functions to set the range for a channel and to set the first/last channels to scan. Tidy up the range and mux register defines. Signed-off-by:
-
H Hartley Sweeten authored
Move this function to remove the need for the forward declaration. Rename it so it has namespace associated with the driver. Remove the unnecessary comedi_subdevice parameter from the function. The hardware does not support analog input channel scanning so the mux and range need to be set before each (*insn_read) and when advancing to the next channel in an async command. Instead of storing the last chan/range in the private data just store the chanspec to determine if the mux and range need to be changed. Refactor pcl812_reset() a bit so we can use the helper function to set the mux and range. Define the bits in the mux register to remove the magic values. Signed-off-by:
-
H Hartley Sweeten authored
Define the bits in the status register. Writing any value to the status register clears any pending interrupt. For aesthetics, rename the status register and remove the "clrint" register. Signed-off-by:
-
H Hartley Sweeten authored
Define the bits in the status register. Signed-off-by:
-
H Hartley Sweeten authored
Define the bits in the status register and remove the magic values. Writing any value to the status register clears any pending interrupt. For aesthetics, rename the status register and remove the "clrint" register. Signed-off-by:
-
