Skip to content
GitLab
  1. Apr 19, 2009
    • Tejun Heo's avatar
      ide kill unused ide_cmd->special · 46a802e8
      Tejun Heo authored 
      

Impact: removal of unused field

No one uses ide_cmd->special anymore.  Kill it.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      46a802e8
    • Tejun Heo's avatar
      ide: don't set REQ_SOFTBARRIER · 55f3f399
      Tejun Heo authored 
      

ide doesn't have to worry about REQ_SOFTBARRIER.  Don't set it.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      55f3f399
    • Tejun Heo's avatar
      ide: use blk_run_queue() instead of blk_start_queueing() · 853280a4
      Tejun Heo authored 
      

blk_start_queueing() is being phased out in favor of
[__]blk_run_queue().  Switch.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      853280a4
    • Tejun Heo's avatar
      ide-tape: remove back-to-back REQUEST_SENSE detection · 1e75540e
      Tejun Heo authored 
      

Impact: fix an oops which always triggers

ide_tape_issue_pc() assumed drive->pc isn't NULL on invocation when
checking for back-to-back request sense issues but drive->pc can be
NULL and even when it's not NULL, it's not safe to dereference it once
the previous command is complete because pc could have been freed or
was on stack.  Kill back-to-back REQUEST_SENSE detection.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      1e75540e
    • Tejun Heo's avatar
      block: clear req->errors on bio completion only for fs requests · 6f41469c
      Tejun Heo authored 
      

Impact: subtle behavior change

For fs requests, rq is only carrier of bios and rq error status as a
whole doesn't mean much.  This is the reason why rq->errors is being
cleared on each partial completion of a request as on each partial
completion the error status is transferred to the respective bios.

For pc requests, rq->errors is used to carry error status to the
issuer and thus __end_that_request_first() doesn't clear it on such
cases.

The condition was fine till now as only fs and pc requests have used
bio and thus the bio completion path.  However, future changes will
unify data accesses to bio and all non fs users care about rq error
status.  Clear rq->errors on bio completion only for fs requests.

In general, the implicit clearing is a bit too subtle especially as
the meaning of rq->errors is completely dependent on low level
drivers.  Unifying / cleaning up rq->errors usage and letting llds
manage it would be better.  TODO comment added.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Acked-by: default avatarJens Axboe <axboe@kernel.dk>
      6f41469c
  3. Apr 18, 2009