1. Dec 19, 2013
    • David S. Miller's avatar
      Merge branch 'bond_locking' · 405a96d6
      David S. Miller authored
      
      
      Ding Tianhong says:
      
      ====================
      Jay Vosburgh said that the bond_3ad_adapter_speed_changed and
      bond_3ad_adapter_duplex_changed is called with RTNL only, and
      the functions will modify the port's information with no further
      locking, they will not mutex against bond state machine and
      incoming LACPDU which do not hold RTNL, So I add port lock to
      protect the port information.
      
      But they are not critical bugs, they exist since day one, and till
      now they have never been hit and reported, because change for speed
      and duplex is very rare, and will not occur critical problem.
      
      The comments in the function is very old, cleanup the comments together.
      ====================
      
      Signed-off-by: default avatarJay Vosburgh <fubar@us.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      405a96d6
    • dingtianhong's avatar
      bonding: protect port for bond_3ad_handle_link_change() · 108db736
      dingtianhong authored
      
      
      The bond_3ad_handle_link_change is called with RTNL only,
      and the function will modify the port's information with
      no further locking, it will not mutex against bond state
      machine and incoming LACPDU which do not hold RTNL, So I
      add __get_state_machine_lock to protect the port.
      
      But it is not a critical bug, it exist since day one, and till
      now it has never been hit and reported, because changes to
      speed is very rare, and will not occur critical problem.
      
      The comments in the function is very old, cleanup it and
      add a new pr_debug to debug the port message.
      
      Signed-off-by: default avatarDing Tianhong <dingtianhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      108db736
    • dingtianhong's avatar
      bonding: protect port for bond_3ad_adapter_duplex_changed() · bca44a73
      dingtianhong authored
      
      
      Jay Vosburgh said that the bond_3ad_adapter_duplex_changed is
      called with RTNL only, and the function will modify the port's
      information with no further locking, it will not mutex against
      bond state machine and incoming LACPDU which do not hold RTNL,
      So I add __get_state_machine_lock to protect the port.
      
      But it is not a critical bug, it exist since day one, and till
      now it has never been hit and reported, because changes to
      speed is very rare, and will not occur critical problem.
      
      The comments in the function is very old, cleanup it.
      
      Suggested-by: default avatarJay Vosburgh <fubar@us.ibm.com>
      Signed-off-by: default avatarDing Tianhong <dingtianhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bca44a73
    • dingtianhong's avatar
      bonding: protect port for bond_3ad_adapter_speed_changed() · 71a06c59
      dingtianhong authored
      
      
      Jay Vosburgh said that the bond_3ad_adapter_speed_changed is
      called with RTNL only, and the function will modify the port's
      information with no further locking, it will not mutex against
      bond state machine and incoming LACPDU which do not hold RTNL,
      So I add __get_state_machine_lock to protect the port.
      
      But it is not a critical bug, it exist since day one, and till
      now it has never been hit and reported, because changes to
      speed is very rare, and will not occur critical problem.
      
      The comment in the function is very old, cleanup it.
      
      Suggested-by: default avatarJay Vosburgh <fubar@us.ibm.com>
      Signed-off-by: default avatarDing Tianhong <dingtianhong@huawei.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      71a06c59
  2. Dec 18, 2013
  3. Dec 17, 2013
  4. Dec 16, 2013