- Feb 26, 2016
-
-
Aaro Koskinen authored
Simplify if statement to avoid deep nesting. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Aaro Koskinen authored
Since we always search the same list, we can just pass the transfer type. Signed-off-by:
-
Aaro Koskinen authored
current_frame always equals usb->frame_number. Signed-off-by:
-
Aaro Koskinen authored
Align split lines to match open parenthesis. Signed-off-by:
-
Aaro Koskinen authored
Use preferred coding style for NULL comparison. Signed-off-by:
-
Bhaktipriya Shridhar authored
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)). It clarifies the divisor calculations. This occurence was detected using the coccinelle script: @@ expression e1; expression e2; @@ ( - ((e1) + e2 - 1) / (e2) + DIV_ROUND_UP(e1,e2) | - ((e1) + (e2 - 1))/ (e2) + DIV_ROUND_UP(e1,e2) ) The macro CEILING was dropped altogether and has been replaced with DIV_ROUND_UP. Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Do not print message if kzalloc() failed. kzalloc() has its own messages. So no need to add extra one. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Eliminate local variable 'ret' and modify return statement to contain the value being returned directly instead of assigning it first to 'ret' and returning this variable. Coccinelle semantic patch used: @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Alison Schofield authored
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch renames u16reason to reason to remove u16 prefix. There is no need to use prefix to show data type. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch renames struct tstrDisconnectNotifInfo to disconnect_info to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames u16ConnectStatus to status to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames u16RespIEsLen to resp_ies_len to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames pu8RespIEs to resp_ies to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames ReqIEsLen to req_ies_len to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames pu8ReqIEs to req_ies to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch renames au8bssid to bssid to remove au8 prefix in struct connect_info. There is no need to use prefix to show data type of this variable. Signed-off-by:
-
Chaehyun Lim authored
This patch renames struct tstrConnectInfo to connect_info to avoid camelcase and removes typedef. Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by:
-
Tony Cho authored
This patch removes the multiple blank line reported by checkpatch.pl. Signed-off-by:
Tony Cho <tony.cho@atmel.com> Signed-off-by:
-
Tony Cho authored
This patch removes unnecessary blank lines found by checkpatch.pl. Signed-off-by:
-
Leo Kim authored
This reverts commit 6c2ab239 ("staging: wilc1000: remove spaces around '->'"). It had applied from a incorrectly commit a1b56a4c ("staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages"). Signed-off-by:
Leo Kim <leo.kim@atmel.com> Signed-off-by:
-
Leo Kim authored
This patch removes unnecessary retry 3 times and related variable. Actually the retry 3 times sentence, don't retry at all. Repeats conditions are that until read a chip-id and written a register. Signed-off-by:
-
Chaehyun Lim authored
This patch removes unnecessary whitespace before a quoted newline found by checkpatch WARNING: unnecessary whitespace before a quoted newline Signed-off-by:
-
Chaehyun Lim authored
This patch fixes line over 80 characters found by checkpatch WARNING: line over 80 characters Signed-off-by:
-
Chaehyun Lim authored
This patch fixes logical continuations found by checkpatch CHECK: Logical continuations should be on the previous line Signed-off-by:
-
Chaehyun Lim authored
wid_cnt variable is used as indicating array index of struct wid_list. This patch renames wid_cnt to i that makes more readability. Signed-off-by:
-
Chaehyun Lim authored
This patch changes data type of wid_cnt from u8 to int. This variable uses array index of struct wid_list so that it is better to use int type. Signed-off-by:
-
Chaehyun Lim authored
This struct just wrap struct cfg_param_val. There is no other member except struct cfg_param_val. This patch remove struct cfg_param_attr, then struct cfg_param_val is renamed to struct cfg_param_attr. Signed-off-by:
-
Chaehyun Lim authored
commit 31cc9885 ("staging: wilc1000: handle_set_mac_address: use kmemdup") introduces a new checkpatch warning, so this patch fixes it. WARNING: Missing a blank line after declarations FILE: drivers/staging/wilc1000/host_interface.c:430: Signed-off-by:
-
Bhumika Goyal authored
Use list_for_each_entry instead of list_for_each and list_entry as it simplifies the code. Done using coccinelle: @@ type T,T2; identifier I1,I2; expression e1,e2; iterator name list_for_each_entry; iterator name list_for_each; @@ - T *I1; ... - list_for_each(I1,e1) + list_for_each_entry(I2,e1,e2) { ...when!=T *I1; - I2=list_entry(I1,T2,e2); ... } ...when!=I2; @@ type T,T2,T3; identifier I1,I2,I3; expression e1,e2; @@ - T *I1; + T3 *I3; ... - list_for_each(I1,e1) + list_for_each_entry(I3,e1,e2) { ...when!=T *I1; - T3 *I3=list_entry(I1,T2,e2); ... } ...when!=I3; Signed-off-by:Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Anchal Jain authored
For single statment of if not required a braces {}. Signed-off-by:Anchal Jain <anchalj109@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace comparison with zero with ! operator. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Removed unncessary braces from the if-else block to remove the following checkpatch.pl warning: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: -
Amitoj Kaur Chawla authored
Use swap() function instead of using a temporary variable for swapping two variables. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @@ type T; T a,b,c; @@ - a = b; - b = c; - c = a; + swap(b, c); //<smpl> Signed-off-by:
-
Dmitry Eremin authored
NFS can ask to encode dentries that are not connected to the root. The fix check for parent is NULL and encode a file handle accordingly. Reviewed-on: http://review.whamcloud.com/8347 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4231 Reviewed-by:
Fan Yong <fan.yong@intel.com> Reviewed-by:
James Simmons <uja.ornl@gmail.com> Reviewed-by:
Jian Yu <jian.yu@intel.com> Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Acked-by:
Jeff Layton <jlayton@poochiereds.net> Signed-off-by:
-
Amitoj Kaur Chawla authored
ll_iget() has been modified to always return NULL in case of error and not a ERR_PTR. Consequently, remove unnecessary IS_ERR tests as now ll_iget() function can never return a ERR_PTR. Additionally, reinitialising root and inode to NULL has been removed since they have already been tested for the same. Signed-off-by:
-
Oleg Drokin authored
ll_orphan_dentry_list and ll_conn_chain are not used and could be removed. Signed-off-by:
-
Oleg Drokin authored
obd_register_page_removal_cb, obd_unregister_page_removal_cb obd_register_lock_cancel_cb, obd_unregister_lock_cancel_cb Signed-off-by:
-
Oleg Drokin authored
There were some messages in Lustre that ended with a space followed by a newline which is pointless, so remove the extra spaces. Found with checkpatch. Signed-off-by:
-
