- Apr 26, 2014
-
-
Mark Einon authored
Sparse complains about halbtc8192e2ant_low_penalty_ra() not being used, and subsequently halbtc8192e2ant_set_sw_penalty_tx_rateadaptive() when this is removed. remove both functions. Signed-off-by:
Mark Einon <mark@einon.net> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mark Einon authored
In halbtc8192e2ant.c, fix all instances of the sparse warning: warning: symbol 'xxx' was not declared. Should it be static? Signed-off-by:
-
Mark Einon authored
Remove functions not being called from anywhere: halbtc8192e2ant_set_adc_backoff() halbtc8192e2ant_adc_backoff() Signed-off-by:
-
Mark Einon authored
All code in this file is encapsulated in a useless #if 1 declaration, remove it. Signed-off-by:
-
Joel Pelaez Jorge authored
The two declarations with issues in rtl_wx.h: * function: struct iw_statistics *r8192_get_wireless_stats(); * variable: extern struct iw_handler_def r8192_wx_handlers_def; The symbol 'r8192_get_wireless_stats' is declared as 'extern' but it is only used in the local scope. The declaration is deleted of rtl_wx.h, fixing the conflict with the 'extern' and 'static' scope. The symbol 'r8192_wx_handlers_def' was fixed of some issues related to variable declaration marked as 'extern' implicitly, causing this sparse warning: drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static? Resolved incluing the fixed header to rtl_wx.c Also, isn't declared as constant variable, so it declared as such. And delete unnecessary cast in rtl_core.c. Signed-off-by:
Joel Pelaez Jorge <joelpelaez@gmail.com> Signed-off-by:
-
Paul McQuade authored
ERROR: spaces required around that '=' (ctx:OxW) Signed-off-by:
Paul McQuade <paulmcquad@gmail.com> Signed-off-by:
-
Dan Carpenter authored
The ->SupportedRates[] array has NDIS_802_11_LENGTH_RATES_EX (16) elements. Since "ie_len" comes from then network and can go up to 255 then it means we should add a range check to prevent memory corruption. Fixes: d6846af6 ('staging: r8188eu: Add files for new driver - part 7') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Loïc Pellegrino authored
Fix coding style problems (incorrect indentation). Signed-off-by:
Loïc Pellegrino <oort10@gmail.com> Signed-off-by:
-
huanqi chi authored
fix a coding style issue: Missing a blank line after declarations Signed-off-by:
huanqi chi <chihuanqi@gmail.com> Signed-off-by:
-
Daeseok Youn authored
The pci_get_drvdata() and checking NULL for dev are called twice in while loop in is_bypass_dev(). Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Neil Armstrong authored
checkpatch script returns the following warning: ERROR: do not use assignment in if condition + if (((dev_num = get_dev_idx(dev->ifindex)) == -1) | This patch fixes the if condition by splitting it. Signed-off-by:Neil Armstrong <superna9999@gmail.com> Signed-off-by:
-
SeongJae Park authored
Some code is hide inside #ifdef BP_PROC_SUPPORT and it never defined anywhere. And, it made defined but not used function which calling code was hide inside #ifdef BP_PROC_SUPPORT and caused following build warning: drivers/staging/silicom/bpctl_mod.c:6786:12: warning: ‘bp_proc_create’ defined but not used [-Wunused-function] static int bp_proc_create(void) ^ Fix the warning and remove code complexity by remove whole code inside #ifdef BP_PROC_SUPPORT. Signed-off-by:SeongJae Park <sj38.park@gmail.com> Signed-off-by:
-
Ken Cox authored
Add x86_cpu_id struct and call to MODULE_DEVICE_TABLE so this module will be auto loaded on boot. Signed-off-by:
Ken Cox <jkc@redhat.com> Tested-by:
-
Benjamin Romer authored
This patch changes all of the various representations of the copyright symbol to (C). Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Masanari Iida authored
Fix spelling typo in comments and printk within unisys. Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Masanari Iida authored
Fix format string mismatch in info_proc_read() within virthba.c. Signed-off-by:
-
Rui Miguel Silva authored
fix sparse warning: drivers/staging/keucr/smilmain.c:163:5: warning: symbol 'Check_D_MediaFmt' was not declared. Should it be static? by declaring it in the right header. And remove duplication of definition of SM_INIT Signed-off-by:
Rui Miguel Silva <rmfrfs@gmail.com> Signed-off-by:
-
Jonas Hahnfeld authored
This patches fixes two warnings of checkpatch.pl, both of the type WARNING: Missing a blank line after declarations Signed-off-by:
Jonas Hahnfeld <hahnjo@hahnjo.de> Signed-off-by:
-
Gioh Kim authored
Because sg_table is cleared in sg_alloc_table via memset we don't need to use kzalloc to allocate sg_table. Signed-off-by:
Gioh Kim <gioh.kim@lge.com> Signed-off-by:
-
Bintian Wang authored
ram_console is replaced by pstore and pstore_ram drivers, and there is no code to use this head file, so remove it. Signed-off-by:
Bintian Wang <bintian.wang@huawei.com> Acked-by:
Colin Cross <ccross@android.com> Signed-off-by:
-
Fabio Falzoi authored
Fixed the following sparse complaints: drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1039:61: warning: restricted gfp_t degrades to integer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1092:61: warning: restricted gfp_t degrades to integer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1136:58: warning: incorrect type in argument 2 (different base types) expected unsigned int [unsigned] gfp_mask got restricted gfp_t [usertype] gfp_mask drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1142:34: warning: incorrect type in argument 3 (different base types) expected unsigned int [unsigned] gfp_mask got restricted gfp_t [usertype] gfp_mask drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1147:58: warning: incorrect type in argument 2 (different base types) expected unsigned int [unsigned] gfp_mask got restricted gfp_t [usertype] gfp_mask drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:1153:34: warning: incorrect type in argument 3 (different base types) expected unsigned int [unsigned] gfp_mask got restricted gfp_t [usertype] gfp_mask Signed-off-by:
Fabio Falzoi <fabio.falzoi84@gmail.com> Signed-off-by:
-
Fabio Falzoi authored
Fixed the following sparse complaints: drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:549:22: warning: symbol 'ldlm_srv_pool_ops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:555:22: warning: symbol 'ldlm_cli_pool_ops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:681:1: warning: symbol 'lprocfs_pool_state_fops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:697:1: warning: symbol 'lprocfs_grant_plan_fops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:700:1: warning: symbol 'lprocfs_wr_recalc_period' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:708:1: warning: symbol 'lprocfs_recalc_period_fops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:710:1: warning: symbol 'ldlm_pool_u64_fops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:711:1: warning: symbol 'ldlm_pool_atomic_fops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:712:1: warning: symbol 'ldlm_pool_rw_atomic_fops' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:714:1: warning: symbol 'lprocfs_grant_speed_fops' was not declared. Should it be static? Signed-off-by:
-
Fabio Falzoi authored
Fixed the following sparse complaints: drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:755:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:757:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:758:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:759:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:760:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:762:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:764:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:765:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:766:9: warning: Using plain integer as NULL pointer drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:768:9: warning: Using plain integer as NULL pointer Signed-off-by:
-
Dan Carpenter authored
We copy "hdr->ioc_len" from the user twice but we only verify that it's within the limit on the first copy. Otherwise we could read unmapped memory and Oops. Signed-off-by:
Peng Tao <bergwolf@gmail.com> Signed-off-by:
-
Vitaly Osipov authored
Fixed several sparse "warning: incorrect type" by replacing int declarations with gfp_t Signed-off-by:
Vitaly Osipov <vitaly.osipov@gmail.com> Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, rename this function so it has namespace associated with the driver. Also, change it's parameters. The cmd->chanlist and cmd->chanlist_len are always passed, just pass the comedi_cmd pointer instead. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is set to the "mode" that the ai command is operating in but nothing uses it. Just remove it. Signed-off-by:
-
H Hartley Sweeten authored
This helper function is called by the ai (*do_cmd) to setup and start the async command based on the "mode" of operation. This "mode" is determined by the cmd convert_src and start_src. Move this "mode" determination and combine the functions. Signed-off-by:
-
H Hartley Sweeten authored
In Step 1 of the (*do_cmdtest), the cmd->scan_begin_src is checked to only allow TRIG_FOLLOW. The (*do_cmd) does not need to recheck this. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is just a copy of the s->async->prealloc_bufsz. Use that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is just a copy of the cmd->stop_arg. Use that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is just a copy of the cmd->chanlist_len. Use that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is just a copy of the cmd->chanlist. Use that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is just a copy of the cmd->flags. Use that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is just a copy of the cmd->convert_arg. Use that instead and remove the unnecessary sanity checking since it was already validated in the (*do_cmdtest). Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is set to 0 but it is never used. Just remove it. Signed-off-by:
-
Chase Southwood authored
The board supported by this driver does not have analog outputs. Remove the subdevice init for it. Signed-off-by:
Chase Southwood <chase.southwood@gmail.com> Reviewed-by:
-
Chase Southwood authored
This board does not have analog inputs. Remove the subdevice init for them. Signed-off-by:
-
Chase Southwood authored
Using the addi-data "common" code in addi_apci_1564 introduces a lot of bloat. By separating this driver off from addi_common.c, a lot of the common code can be stripped out. This patch copies the code over from addi_common.c, and removes the #include of the file. The auto_attach function from the common code replaces the one that was previously in this driver, though renamed to that it stays within the namespace associated with this driver, and the detach function has been renamed for this reason as well. Signed-off-by:
Chase Southwood <chase.southwood@yahoo.com> Reviewed-by:
-
H Hartley Sweeten authored
When the cmd->scan_begin_src == TRIG_TIMER the divisors needed to generate the pacer time are calculated in the (*do_cmdtest) to validate the cmd->scan_begin_arg. The core always does the (*do_cmdtest) before the (*do_cmd) so there is no reason to recalc the divisors. Signed-off-by:
-
