- Jun 20, 2019
-
-
Nishka Dasgupta authored
Change return type of function r8712_setstakey_cmd() to void as its return value is never stored, checked, or otherwise used. Signed-off-by:
Nishka Dasgupta <nishkadg.linux@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Nishka Dasgupta authored
Change return type of function r8712_setopmode_cmd() from u8 to void as its return value is never stored or checked or otherwise used. Signed-off-by:
-
Nishka Dasgupta authored
Change return type of function r8712_disassoc_cmd from u8 to void as its return value is never stored, checked or otherwise used. Modify its return statements accordingly. Signed-off-by:
-
Nishka Dasgupta authored
Change return type of function r8712_set_chplan_cmd from u8 to void as its return value is never stored, checked or otherwise used. Change the return statements accordingly. Signed-off-by:
-
Nishka Dasgupta authored
Change the return types of r8712_enqueue_cmd to void as the return value of r8712_enqueue_cmd is never stored, checked, or otherwise used. Also change the return type of _enqueue_cmd to void as it is only called by r8712_enqueue_cmd which does not do anything with the return value except return it itself. Modify return statements in both functions accordingly. Signed-off-by:
-
Nishka Dasgupta authored
Change return values of function r8712_joinbss_cmd from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Change return type from u8 to int to accommodate return of -ENOMEM. Similarly, change the return values (_SUCCESS to 0 and _FAIL to -ENOMEM or -EINVAL) and type (sint to int) of the call site of r8712_joinbss_cmd, r8712_select_and_join_from_scan, as one of the branches of r8712_select_and_join_from_scan directly returns the return value of r8712_joinbss_cmd. Modify the call sites of r8712_select_and_join_from_scan to check for 0 instead of _SUCCESS. Issue found with Coccinelle. Signed-off-by:
-
Nishka Dasgupta authored
Remove the check for whether the value of variable psecnetwork is NULL as psecnetwork is a field of a field of a non-NULL pointer, and therefore cannot be NULL itself. Signed-off-by:
-
Nishka Dasgupta authored
Remove leading 'p' from the name of the pointer variable padapter. Issue found with Coccinelle. Signed-off-by:
-
Nishka Dasgupta authored
Remove leading p from the names of the following pointer variables: - padapter - pmlmepriv - psec_priv. Issue found with Coccinelle. Signed-off-by:
-
Sergio Paracuellos authored
Both driver and device tree have been updated to use GPIO perst. Update bindings documentation also. Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
Driver has been changed to use perts gpio reset instead of perst builtin behaviour. Update device tree accordly. Signed-off-by:
-
Sergio Paracuellos authored
Some boards seems to ignore the PERST builtin behaviour to properly perform a pcie line reset. Use gpio PERST behaviour instead which seems to be more common. Fixes: bd1a05bd ("staging: mt7621-pci: use PERST_N instead of gpio control") Signed-off-by:
-
Sergio Paracuellos authored
There are two messages in driver code which are not correct. Fix both of them to clarify boot runs. Signed-off-by:
-
Michael Straube authored
Remove unused and/or commented code from rtw_wlan_util.c. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove function soft_reset_sd_card, as all it does is call reset_sd. Modify call sites of the former to call the latter instead. Issue found with Coccinelle. Signed-off-by:
-
Shobhit Kukreti authored
Resolve indentation errors which were caused by a mix of space and tabs for indentation. Previous patch to fix if-else brace styles revealed the indentation error Signed-off-by:
Shobhit Kukreti <shobhitkukreti@gmail.com> Signed-off-by:
-
Shobhit Kukreti authored
Cleaned up the code to resolve the checkpatch error else should follow close brace '}' from the following files: mlme_linux.c recv_linux.c sdio_intf.c Signed-off-by:
-
Shobhit Kukreti authored
staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Cleaned up the code from the following files to get rid of check patch error "that open brace { should be on the previous line" drivers/staging/rtl8723bs/os_dep/mlme_linux.c drivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/rtw_proc.c drivers/staging/rtl8723bs/os_dep/sdio_intf.c drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c Signed-off-by: -
Hariprasad Kelam authored
Remove pHalData variable as it is set but unused in function. Remove pU1Tmp and replace this with pu8 Signed-off-by:
Hariprasad Kelam <hariprasad.kelam@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Colin Ian King authored
The break statement is indented one level too deep, fix this. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Hariprasad Kelam authored
this patch fixes below issue reported by checkpatch.pl CHECK: Lines should not end with a '(' CHECK: Lines should not end with a '(' Signed-off-by: -
Hariprasad Kelam authored
This patch is a cleanup which replaces rtw_malloc(wep_total_len) with kzalloc() and removes the memset(). The rtw_malloc() does GFP_ATOMIC allocations when in_atomic() is true. But as the comments for in_atomic() describe, the in_atomic() check should not be used in driver code. The in_atomic() check is not accurate when preempt is disabled. In this code we are not in IRQ context and we are not holding any spin_locks so GFP_KERNEL is safe. Signed-off-by:
-
Shobhit Kukreti authored
Cleaned Up code to fix brace style issues reported by checkpatch: -space required before the open brace '{' -Unbalanced braces around if/else statements Signed-off-by: -
Shobhit Kukreti authored
Removing comparisons to True/False in if statements. Checkpatch reported: CHECK: Using comparison to true is error prone Signed-off-by:
-
Hariprasad Kelam authored
this patch fixes below issues reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by:
-
Hariprasad Kelam authored
This patch fixes below issues reported by checkpatch CHECK: Comparison to NULL could be written "psta" CHECK: Comparison to NULL could be written "pmlmepriv->wps_probe_resp_ie" CHECK: Comparison to NULL could be written "psta" Signed-off-by:
-
Colin Ian King authored
Currently there are several left shifts that are assigned to 64 bit unsigned longs where a signed int 1 is being shifted, resulting in an integer overflow. Fix this bit using the BIT_ULL macro to perform a 64 bit shift. Also clean up an overly long statement. Addresses-Coverity: ("Unintentional integer overflow") Fixes: 7dc7967f ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by: -
Simon Sandström authored
We can get rid of a few iounmaps in the middle of the function by re-ordering the error handling labels and adding two new labels. Signed-off-by:
Simon Sandström <simon@nikanor.nu> Reviewed-by:
-
Hariprasad Kelam authored
kmalloc followed by memset can be replaced with kzalloc. Signed-off-by:
-
Hariprasad Kelam authored
alloc_etherdev function internally calls kvzalloc . So we may not need explicit memset after this call. Signed-off-by:
-
Hariprasad Kelam authored
alloc_etherdev function internally calls kvzalloc . So we may not need explicit memset after this call. Signed-off-by:
-
Hariprasad Kelam authored
alloc_etherdev function internally calls kvzalloc . So we may not need explicit memset after this call. Signed-off-by:
-
Bastien Nocera authored
I don't have easy access to this hardware anymore. Signed-off-by:
Bastien Nocera <hadess@hadess.net> Signed-off-by:
-
Colin Ian King authored
The break statement is indented one level too deep, fix this. Signed-off-by:
Quentin Deslandes <quentin.deslandes@itdev.co.uk> Signed-off-by:
-
- Jun 18, 2019
-
-
Hariprasad Kelam authored
Remove function ODM_ConfigMACWithHeaderFile as trace is not necessary and as it is getting called only once and call direct function "ODM_ReadAndConfig_MP_8723B_MAC_REG" Issue identified by coccicheck Signed-off-by:
-
Hariprasad Kelam authored
ERROR: spaces required around that '<<' (ctx:VxV) Signed-off-by:
-
Hariprasad Kelam authored
Remove variable pHalData as it is not being used in function. Signed-off-by:
-
Hariprasad Kelam authored
This patch tries to fix below issues reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to true is false prone Signed-off-by:
-
Hariprasad Kelam authored
This patch tries to fix below issues reported by checkpatch CHECK: Comparison to NULL could be written "!efuseTbl" CHECK: Comparison to NULL could be written "!psta" Signed-off-by:
-
Hariprasad Kelam authored
rtw_zmalloc is internally doing memset . So there is no need to call memset again. Signed-off-by:
-
