1. Dec 19, 2008
  2. Dec 18, 2008
    • KOSAKI Motohiro's avatar
      locking, irq: enclose irq_desc_lock_class in CONFIG_LOCKDEP · 74c8a613
      KOSAKI Motohiro authored
      Impact: simplify code
      
      commit "08678b08
      
      : generic: sparse irqs: use irq_desc() [...]" introduced
      the irq_desc_lock_class variable.
      
      But it is used only if CONFIG_SPARSE_IRQ=Y or CONFIG_TRACE_IRQFLAGS=Y.
      Otherwise, following warnings happen:
      
      	CC      kernel/irq/handle.o
      	kernel/irq/handle.c:26: warning: 'irq_desc_lock_class' defined but not used
      
      Actually, current early_init_irq_lock_class has a bit strange and messy ifdef.
      In addition, it is not valueable.
      
      1. this function is protected by !CONFIG_SPARSE_IRQ, but that is not necessary.
         if CONFIG_SPARSE_IRQ=Y, desc of all irq number are initialized by NULL
         at first - then this function calling is safe.
      
      2. this function protected by CONFIG_TRACE_IRQFLAGS too. but it is not
         necessary either, because lockdep_set_class() doesn't have bad side
         effect even if CONFIG_TRACE_IRQFLAGS=n.
      
      This patch bloat kernel size a bit on CONFIG_TRACE_IRQFLAGS=n and
      CONFIG_SPARSE_IRQ=Y - but that's ok. early_init_irq_lock_class() is not
      a fastpatch at all.
      
      To avoid messy ifdefs is more important than a few bytes diet.
      
      Signed-off-by: default avatarKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      74c8a613
    • Jeremy Fitzhardinge's avatar
      sparseirq, xen: make sure irq_desc is allocated for interrupts · 6f8a0ed4
      Jeremy Fitzhardinge authored
      
      
      Impact: fix crash
      
      Make sure all Xen irqs have an irq_desc.
      
      Signed-off-by: default avatarJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      6f8a0ed4
  3. Dec 17, 2008
  4. Dec 16, 2008
  5. Dec 12, 2008
  6. Dec 10, 2008
    • Yinghai Lu's avatar
      sparseirq: fix !SMP && !PCI_MSI && !HT_IRQ build · 8a4830f8
      Yinghai Lu authored
      Ingo Molnar wrote:
      
      >>>  drivers/pci/intr_remapping.c: In function 'irq_2_iommu_alloc':
      >>>  drivers/pci/intr_remapping.c:72: error: 'boot_cpu_id' undeclared (first use in this function)
      >>>  drivers/pci/intr_remapping.c:72: error: (Each undeclared identifier is reported only once
      >>>  drivers/pci/intr_remapping.c:72: error: for each function it appears in.)
      
      sparseirq should only be used with SMP for now.
      8a4830f8
  7. Dec 09, 2008
  8. Dec 08, 2008
  9. Dec 06, 2008
  10. Dec 05, 2008