- May 19, 2022
-
-
Martin Kaiser authored
Read the back action code from struct ieee80211_mgmt. struct ieee80211_mgmt contains an "action" union. Each of its members starts with an 8-bit action code. Treat the union as addba_req when we read the action code although we do not yet know if it is an addba_req. This approach is similar to ieee80211_iface_process_skb. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220508161451.115847-6-martin@kaiser.cx Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Martin Kaiser authored
Use the defines from ieee80211.h for the back action codes. Signed-off-by:
-
Martin Kaiser authored
For management frames, addr1 is the destination address (da). Read this address from struct ieee80211_mgmt instead of calling a driver-specific macro. Signed-off-by:
-
Martin Kaiser authored
Do not check the category in OnAction_back. OnAction has already checked the category before calling OnAction_back. Signed-off-by:
-
Martin Kaiser authored
Define a struct ieee80211_mgmt variable in the OnAction_back function. Use it to read addr2. For management frames, addr2 is the source address (sa). Signed-off-by:
-
Colin Ian King authored
Don't populate the const array queuetopipe on the stack, instead make it static. Also makes the object code smaller. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20220507183414.26633-1-colin.i.king@gmail.com Signed-off-by:
-
- May 06, 2022
-
-
Martin Kaiser authored
The IEEE_* defines in the driver's ieee80211.h header file are not used. Remove them. Signed-off-by:
-
Martin Kaiser authored
Replace some of the driver-specific defines for action categories with the defines from ieee80211.h. Signed-off-by:
-
Martin Kaiser authored
Use the struct ieee80211_mgmt from ieee80211.h to read the action category. There's no need to parse the incoming frame ourselves. Signed-off-by:
-
Martin Kaiser authored
OnAction_tbl has only three entries. It's simpler to use a switch statement instead of iterating over the table. We can then remove the table itself and struct action_handler, which was used only for the table entries. Signed-off-by:
-
Martin Kaiser authored
RTW_WLAN_CATEGORY_TDLS is not used. Remove the define. Signed-off-by:
-
Martin Kaiser authored
Remove the unused str component from struct action_handler and the corresponding entries in OnAction_tbl. Signed-off-by:
-
Martin Kaiser authored
For some action categories, we removed the handler function, but we forgot the prototypes. Remove them as well. Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver does not handle the wmm action category. Remove the empty handler function, the entry in OnAction_tbl and the define for the category. Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver does not handle the ht action category. Remove the empty handler function, the entry in OnAction_tbl and the define for the category. Signed-off-by:
-
Philipp Hortmann authored
Replace unused return value with u64 to increase readability, reduce address and dereference operators and omit pqwCurrTSF that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/62c83d78627196ec0ce2f5a562cb080a1c87a05a.1651435890.git.philipp.g.hortmann@gmail.com Signed-off-by:
-
Philipp Hortmann authored
The name of the function uses CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Philipp Hortmann authored
Added missing big-endian support in CARDbGetCurrentTSF. Reported-by:
David Laight <David.Laight@ACULAB.COM> Signed-off-by:
-
Philipp Hortmann authored
Replace macro VNSvInPortD with ioread32 and as it was the only user, it can now be removed. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
Charlie Sands authored
Removes broken and unsafe rtw_p2p_get function and all of the code associated with it from the r8188eu driver. Signed-off-by:
Charlie Sands <charlies256@protonmail.com> Link: https://lore.kernel.org/r/Ymy7C/A2q+VzfBhO@sckzor-linux.localdomain Signed-off-by:
-
Vihas Makwana authored
There's a NULL check on pmlmepriv in rtw_mlme.c:112 which makes no sense as rtw_free_mlme_priv_ie_data() dereferences it unconditionally and it would have already crashed at this point. Remove this redundant check. Signed-off-by:
Vihas Makwana <makvihas@gmail.com> Link: https://lore.kernel.org/r/20220427165748.10584-1-makvihas@gmail.com Signed-off-by:
-
Jaehee Park authored
rtw_select_and_join_from_scanned_queue() cannot return '2' so this else condition is unused. Remove this unnecessary else statement. Suggested-by:
Pavel Skripkin <paskripkin@gmail.com> Signed-off-by:
Jaehee Park <jhpark1013@gmail.com> Link: https://lore.kernel.org/r/20220427153203.GA503502@jaehee-ThinkPad-X1-Extreme Signed-off-by:
-
Vihas Makwana authored
The semaphore allrxreturnevt of struct recv_priv is initialized but not used anywhere in the code. Remove the initialization and the structure member. Signed-off-by:
-
Nickalas Cason authored
Correct misspelling in comment. Issue found with checkpatch. Signed-off-by:
Nickalas Cason <nickalas@cason.dev> Link: https://lore.kernel.org/r/20220430230139.7i772mvejlhevamn@desktop Signed-off-by:
-
Andy Shevchenko authored
Instead of custom data type re-use generic struct s32_fract. No changes intended. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20220504092915.72021-1-andriy.shevchenko@linux.intel.com Signed-off-by:
-
- Apr 27, 2022
-
-
Philipp Hortmann authored
Replace macro MACvReadISR with VNSvInPortD and as it was the only user, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvReadMIBCounter with VNSvInPortD and as it was the only user, it can now be removed. Signed-off-by:
-
- Apr 26, 2022
-
-
Philipp Hortmann authored
Replace macro VNSvInPortW with ioread16. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Solomon Tan authored
Remove explicit u16 cast of the function Mk16 return value. The variable hi does not need to be casted explicitly to u16 as it will already be casted implicitly. Signed-off-by:
Solomon Tan <wjsota@gmail.com> Link: https://lore.kernel.org/r/20220423130150.161903-8-wjsota@gmail.com Signed-off-by:
-
Solomon Tan authored
The explicit u16 cast is not necessary because rtl92e_eeprom_read's second parameter is defined to be u32. Signed-off-by:
-
Solomon Tan authored
Remove the explicit u16 casts for u16 argument in the function call. This function has declared its parameter to be of type u16, so the argument given to that parameter will be automatically coerced to u16. Therefore, an explicit cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Remove the explicit casts in assignment statements for u16 variables. Because these variables are declared as u16, there is implicit conversion to u16 during the assignment, so an explicit cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Since the macro VERSION_8190_BD is defined to be 0x3, and the structure members card_8192_version and IC_Cut are both u8, an explicit u8 cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Remove the unnecessary explicit u8 casts for u8 arguments in function calls. These functions have declared their parameters to be of type u8, so the arguments given to those parameters will be automatically coerced to u8. Therefore, an explicit cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Remove the explicit casts in assignment statements for u8 variables. Because these variables are declared as u8, there is implicit conversion to u8 during the assignment, so an explicit cast is unnecessary. Signed-off-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_dequeue_cmd and move its logic to rtw_dequeue_cmd. Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_alloc_network and move its logic to rtw_alloc_network. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_free_mlme_priv and move its logic to rtw_free_mlme_priv. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_init_mlme_priv and move its logic to rtw_init_mlme_priv. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_init_evt_priv and move its logic to rtw_init_evt_priv. Reviewed-by:
-
