- Jun 01, 2012
-
-
J. Bruce Fields authored
Instead of keeping the principal name associated with a request in a structure that's private to auth_gss and using an accessor function, move it to svc_cred. Signed-off-by:J. Bruce Fields <bfields@redhat.com>
-
J. Bruce Fields authored
RFC 5661 actually says we should allow an exchange_id to remove a matching client, even if the exchange_id comes from a different principal, *if* the victim client lacks any state. Signed-off-by: -
J. Bruce Fields authored
Minor cleanup: it's simpler to have separate code paths for the update and non-update cases. Signed-off-by: -
J. Bruce Fields authored
Make these comments a bit more concise and uniform. Signed-off-by: -
J. Bruce Fields authored
Signed-off-by: -
J. Bruce Fields authored
Following rfc 5661 section 2.4.1, we can permit a 4.1 client to remove an established 4.0 client's state. (But we don't allow updates.) Signed-off-by: -
J. Bruce Fields authored
We mustn't allow a client to destroy another client with established state unless it has the right credential. And some minor cleanup. (Note: our comparison of credentials is actually pretty bogus currently; that will need to be fixed in another patch.) Signed-off-by: -
J. Bruce Fields authored
There's no point to the dprintk here as the main proc_compound loop already does this. Signed-off-by: -
J. Bruce Fields authored
We just verified above that these two verifiers are already the same. Signed-off-by: -
J. Bruce Fields authored
Signed-off-by: -
Weston Andros Adamson authored
debugfs read operations were returning the contents of an uninitialized u64. Signed-off-by:
Weston Andros Adamson <dros@netapp.com> Signed-off-by:
-
Jeff Layton authored
Handle the st_deny_bmap in a similar fashion to the st_access_bmap. Add accessor functions and use those instead of bare bitops. Signed-off-by:
Jeff Layton <jlayton@redhat.com> Signed-off-by:
-
Jeff Layton authored
Currently, we do this for the most part with "bare" bitops, but eventually we'll need to expand the share mode code to handle access and deny modes on other nodes. In order to facilitate that code in the future, move to some generic accessor functions. For now, these are mostly static inlines, but eventually we'll want to move these to "real" functions that are able to handle multi-node configurations or have a way to "swap in" new operations to be done in lieu of or in conjunction with these atomic bitops. Signed-off-by:
-
Jeff Layton authored
All of the callers treat the return that way already. Signed-off-by:
-
Jeff Layton authored
These functions are identical. Also, rename them to bmap_to_share_mode to better reflect what they do, and have them just return the result instead of passing in a pointer to the storage location. Signed-off-by:
-
Chuck Lever authored
According to RFC 3530bis, the only items SETCLIENTID_CONFIRM processing should be concerned with is the clientid, clientid verifier, and principal. The client's IP address is not supposed to be interesting. And, NFS4ERR_CLID_INUSE is meant only for principal mismatches. I triggered this logic with a prototype UCS client -- one that uses the same nfs_client_id4 string for all servers. The client mounted our server via its IPv4, then via its IPv6 address. Signed-off-by:
Chuck Lever <chuck.lever@oracle.com> Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by:
-
Stanislav Kinsbursky authored
This is just a code move, which from my POV makes the code look better. I.e. now on start we have 3 different stages: 1) Service creation. 2) Service per-net data allocation. 3) Service start. Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
This function creates service if it doesn't exist, or increases usage counter if it does, and returns a pointer to it. The usage counter will be droppepd by svc_destroy() later in lockd_up(). Signed-off-by:
-
Stanislav Kinsbursky authored
This patch also replaces svc_rpcb_setup() with svc_bind(). Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Jeff Layton authored
There's little point in waiting until after we allocate all of the pages to see if we're going to overrun the array. In the event that this calculation is really off we could end up scribbling over a bunch of memory and make it tougher to debug. Signed-off-by:
-
Stanislav Kinsbursky authored
The idea is to separate service destruction and per-net operations, because these are two different things and the mix looks ugly. Notes: 1) For NFS server this patch looks ugly (sorry for that). But these place will be rewritten soon during NFSd containerization. 2) LockD per-net counter increase int lockd_up() was moved prior to make_socks() to make lockd_down_net() call safe in case of error. Signed-off-by:
-
Stanislav Kinsbursky authored
This new routine is responsible for service registration in a specified network context. The idea is to separate service creation from per-net operations. Note also: since registering service with svc_bind() can fail, the service will be destroyed and during destruction it will try to unregister itself from rpcbind. In this case unregistration has to be skipped. Signed-off-by:
-
J. Bruce Fields authored
The data in Kerberos gss tokens can be rotated. But we were lazy and rejected any nonzero rotation value. It wasn't necessary for the implementations we were testing against at the time. But it appears that Windows does use a nonzero value here. So, implement rotation to bring ourselves into compliance with the spec and to interoperate with Windows. Signed-off-by: -
Weston Andros Adamson authored
The fs_location->hosts list is split on colons, but this doesn't work when IPv6 addresses are used (they contain colons). This patch adds the function nfsd4_encode_components_esc() to allow the caller to specify escape characters when splitting on 'sep'. In order to fix referrals, this patch must be used with the mountd patch that similarly fixes IPv6 [] escaping. Signed-off-by:
-
J. Bruce Fields authored
Though actually this doesn't matter much, as NFSv4.0 clients are required to treat the change attribute as opaque. Signed-off-by: -
J. Bruce Fields authored
Cc: Bryan Schumaker <bjschuma@netapp.com> Signed-off-by: -
J. Bruce Fields authored
In each of these cases there's a simple unambiguous correct choice, and no actual bug. Signed-off-by: -
J. Bruce Fields authored
Reviewed-by:
-
J. Bruce Fields authored
Signed-off-by: -
J. Bruce Fields authored
OK, admittedly I'm mainly just trying to shut sparse up. Signed-off-by:
-
- Apr 26, 2012
-
-
Jeff Layton authored
They're equivalent, but SEEK_SET is more informative... Cc: Eric Sandeen <sandeen@redhat.com> Signed-off-by:
-
Simo Sorce authored
This is needed to share code between the current server upcall mechanism and the new gssproxy upcall mechanism introduced in a following patch. Signed-off-by:
Simo Sorce <simo@redhat.com> Signed-off-by:
-
- Apr 12, 2012
-
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
Stanislav Kinsbursky authored
These functions will be called from per-net operations. Signed-off-by:
-
Stanislav Kinsbursky authored
Signed-off-by:
-
