- Sep 02, 2013
-
-
Lee Jones authored
Error handling is on-its-head in this function. After invoking a function we should examine the return code and return the error value if there was one. Instead, this function checks for success and goes onto provide functionality if success was received. Not so bad in a simple function like this, but in a more complex one this could end up drowning in curly brackets. Signed-off-by:Lee Jones <lee.jones@linaro.org>
-
Lee Jones authored
The AB8500 debugfs driver allocates memory to contain the name of a new sysfs entry, but fails to apply the proper post-allocation checks. If the device were to run out of memory, the allocation would return NULL. Without the correct checks the driver will continue to populate address NULL with the specified device name which would obviously cause a pointer dereference Oops. Signed-off-by: -
Lee Jones authored
The AB8500 debugfs driver allocates memory for a new sysfs entry, but fails to apply the proper post-allocation checks. If the device were to run out of memory, the allocation would return NULL. Without the correct checks the driver will continue to populate NULL->[show|store|...], which would obviously cause a pointer dereference Oops. Signed-off-by: -
Sachin Kamat authored
module_pci_driver removes some boilerplate and makes the code simple. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
-
Sachin Kamat authored
break after goto is unreachable. Delete it. Signed-off-by:
-
Sachin Kamat authored
Local variables referenced only in this file are made static. Acked-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
-
Sachin Kamat authored
Local variables referenced only in this file are made static. Acked-by:
-
Sachin Kamat authored
clk_mgt is used only in this file. Make it static. Acked-by:
-
Sachin Kamat authored
Silences the following warning: drivers/mfd/db8500-prcmu.c:2322:25: warning: non-ANSI function declaration of function 'prcmu_ac_sleep_req' Acked-by:
-
Sachin Kamat authored
usbhs_driver_name is used only in this file. Make it static. Signed-off-by:
-
Chao Xie authored
User pass platform data to device, and platform data may be NULL. Add the check for pdata. Signed-off-by:
Chao Xie <chao.xie@marvell.com> Signed-off-by:
Samuel Ortiz <sameo@linux.intel.com>
-
Chao Xie authored
User pass platform data to device, and platform data may be NULL. Add the check for pdata. Signed-off-by:
-
Samuel Ortiz authored
-
Mark Brown authored
Rather then open coding a cache of the vibra control registers use the regmap cache code. Also cache the interrupt mask register, providing a small performance improvement for the interrupt code. Signed-off-by:
Mark Brown <broonie@linaro.org> Acked-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by:
-
Mark Brown authored
This will be used to support refactoring of the ASoC CODEC driver to use a regmap. Signed-off-by:
-
Mark Brown authored
These functions are not referenced anywhere, nor prototyped, so just remove them. Signed-off-by:
-
- Aug 30, 2013
-
-
Wei WANG authored
Update copyright date, and remove author address. Signed-off-by:
Wei WANG <wei_wang@realsil.com.cn> Acked-by:
Chris Ball <cjb@laptop.org> Signed-off-by:
-
Wei WANG authored
If switching voltage fails, SD_CLK toggle enable bit should been cleared so that SD host can control SD clock automatically. Signed-off-by:
-
Wei WANG authored
The default phase can meet most cards' requirement, but it is not the optimal one. In some extreme situation, the rx phase point produced by the following tuning process will drift quite a distance. Before tuning UHS card, this patch will set a more proper initial tx phase point, which is calculated from statistic data, and can achieve a much better tx signal quality. Signed-off-by:
-
- Aug 21, 2013
-
-
git://git.linaro.org/people/ljones/mfdSamuel Ortiz authored
Signed-off-by:
-
- Aug 20, 2013
-
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
-
Wei WANG authored
Update copyright date, remove author address and add Roger Tseng. Signed-off-by:
-
Wei WANG authored
Set a bit to enable rts5227 and rts5249 to enter a deeper internal power-saving mode in S3, and recover it after resuming. Signed-off-by:
-
Wei WANG authored
Clear hw_pfm_en to disable hardware PFM mode, to fix a bug that in some situation registers in 0xFDxx domain can't be accessed. Signed-off-by:
-
Wei WANG authored
These actions are individual for each reader model, so should be put in extra_init_hw instead of rtsx_pci_init_hw. Signed-off-by:
-
Wei WANG authored
Some actions to clear power state should be handled in .shutdown callback in rtsx_pci_driver. This patch adopts the following measures to catch this goal: 1. Add a function rtsx_pci_power_off to abstract the common ops in .shutdown and .suspend 2. Add pcr->ops->force_power_down to fulfill the individual action for each reader model Signed-off-by:
-
Wei WANG authored
Normally OEMs will set vendor setting to the config space of Realtek card reader in BIOS stage. This patch reads the setting at the first, and configure the internal registers according to it, to improve card reader's compatibility condition. Signed-off-by:
-
Oleksandr Dmytryshyn authored
The TWL6032 PMIC has different IRQ status bits meaning. Hence, add interrupt mapping table for the twl6032. Signed-off-by:
Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com> Signed-off-by:
Grygorii Strashko <grygorii.strashko@ti.com> Acked-by:
Graeme Gregory <gg@slimlogic.co.uk> Signed-off-by:
-
Grygorii Strashko authored
Create "struct twl6030_irq" and place all local variables inside it. Also allocate twl6030_irq structure dynamically during initialization. Signed-off-by:
-
Grygorii Strashko authored
Since the TWL6030 PMIC is used with OMAP4 SoCs only and OMAP4 legacy boot is dropped there are no needs to allocate the range of IRQ descriptors during system boot to support TWL6030 IRQs. Hence, convert it to use linear irq_domain and move IRQ configuration in .map()/.unmap() callbacks of irq_domain. So, IRQ mapping and descriptors allocation will be performed dynamically basing on DT configuration. The error message will be reported in case if unmapped IRQ is received by TWL6030 (virq==0). Signed-off-by:
-
Grygorii Strashko authored
Add a missed check for errors when TWL IRQs are masked initially on probe and report an error in case of failure. Signed-off-by:
-
Naga Venkata Srikanth V authored
1) Removed request_irq() and replaced it with request_threaded_irq(). 2) Removed generic_handle_irq() and replaced it with handle_nested_irq(). Handling of these interrupts is nested, as we are handling an interrupt (for e.g rtc, mmc1) when we are still servicing TWL irq. 3) Removed I2C read-retry logic for the case when twl_i2c_read() is failed inside IRQ handler - there is no sense to do that, so just report an error and return. 4) Each nested IRQ is configured with corresponding parent_irq, which need to be retriggered in case if nested IRQ is marked as IRQS_PENDING. Signed-off-by:
Naga Venkata Srikanth V <vnv.srikanth@samsung.com> Signed-off-by:
Oleg_Kosheliev <oleg.kosheliev@ti.com> Signed-off-by:
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_*() functions to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d063 (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by:
-
Jingoo Han authored
Include <linux/module.h> in order to fix the following errors. drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant Signed-off-by:
-
