Commit fd5256cb authored by yipechai's avatar yipechai Committed by Alex Deucher
Browse files

drm/amdgpu: Remove the redundant code of psp bootloader functions 



The psp bootloader functions code of psp_v13_0.c had been
optimized before. According the code style of psp_v13_0.c
to remove the redundant code of psp_v11_0.c.

v2: squash in drop unused variable (Alex)

Signed-off-by: default avataryipechai <YiPeng.Chai@amd.com>
Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 87172e89

drivers/gpu/drm/amd/amdgpu/psp_v11_0.c

+15 −63
Original line number Diff line number Diff line
@@ -277,13 +277,15 @@ static bool psp_v11_0_is_sos_alive(struct psp_context *psp) 
	return sol_reg != 0x0;

}



static int psp_v11_0_bootloader_load_kdb(struct psp_context *psp)

static int psp_v11_0_bootloader_load_component(struct psp_context  	*psp,

					       struct psp_bin_desc 	*bin_desc,

					       enum psp_bootloader_cmd  bl_cmd)

{

	int ret;

	uint32_t psp_gfxdrv_command_reg = 0;

	struct amdgpu_device *adev = psp->adev;



	/* Check tOS sign of life register to confirm sys driver and sOS

	/* Check sOS sign of life register to confirm sys driver and sOS

	 * are already been loaded.

	 */

	if (psp_v11_0_is_sos_alive(psp))
@@ -293,13 +295,13 @@ static int psp_v11_0_bootloader_load_kdb(struct psp_context *psp) 
	if (ret)

		return ret;



	/* Copy PSP KDB binary to memory */

	psp_copy_fw(psp, psp->kdb.start_addr, psp->kdb.size_bytes);

	/* Copy PSP System Driver binary to memory */

	psp_copy_fw(psp, bin_desc->start_addr, bin_desc->size_bytes);



	/* Provide the PSP KDB to bootloader */

	/* Provide the sys driver to bootloader */

	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,

	       (uint32_t)(psp->fw_pri_mc_addr >> 20));

	psp_gfxdrv_command_reg = PSP_BL__LOAD_KEY_DATABASE;

	psp_gfxdrv_command_reg = bl_cmd;

	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_35,

	       psp_gfxdrv_command_reg);
@@ -308,69 +310,19 @@ static int psp_v11_0_bootloader_load_kdb(struct psp_context *psp) 
	return ret;

}



static int psp_v11_0_bootloader_load_spl(struct psp_context *psp)

static int psp_v11_0_bootloader_load_kdb(struct psp_context *psp)

{

	int ret;

	uint32_t psp_gfxdrv_command_reg = 0;

	struct amdgpu_device *adev = psp->adev;



	/* Check tOS sign of life register to confirm sys driver and sOS

	 * are already been loaded.

	 */

	if (psp_v11_0_is_sos_alive(psp))

		return 0;



	ret = psp_v11_0_wait_for_bootloader(psp);

	if (ret)

		return ret;



	/* Copy PSP SPL binary to memory */

	psp_copy_fw(psp, psp->spl.start_addr, psp->spl.size_bytes);



	/* Provide the PSP SPL to bootloader */

	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,

	       (uint32_t)(psp->fw_pri_mc_addr >> 20));

	psp_gfxdrv_command_reg = PSP_BL__LOAD_TOS_SPL_TABLE;

	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_35,

	       psp_gfxdrv_command_reg);



	ret = psp_v11_0_wait_for_bootloader(psp);

	return psp_v11_0_bootloader_load_component(psp, &psp->kdb, PSP_BL__LOAD_KEY_DATABASE);

}



	return ret;

static int psp_v11_0_bootloader_load_spl(struct psp_context *psp)

{

	return psp_v11_0_bootloader_load_component(psp, &psp->spl, PSP_BL__LOAD_TOS_SPL_TABLE);

}



static int psp_v11_0_bootloader_load_sysdrv(struct psp_context *psp)

{

	int ret;

	uint32_t psp_gfxdrv_command_reg = 0;

	struct amdgpu_device *adev = psp->adev;



	/* Check sOS sign of life register to confirm sys driver and sOS

	 * are already been loaded.

	 */

	if (psp_v11_0_is_sos_alive(psp))

		return 0;



	ret = psp_v11_0_wait_for_bootloader(psp);

	if (ret)

		return ret;



	/* Copy PSP System Driver binary to memory */

	psp_copy_fw(psp, psp->sys.start_addr, psp->sys.size_bytes);



	/* Provide the sys driver to bootloader */

	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,

	       (uint32_t)(psp->fw_pri_mc_addr >> 20));

	psp_gfxdrv_command_reg = PSP_BL__LOAD_SYSDRV;

	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_35,

	       psp_gfxdrv_command_reg);



	/* there might be handshake issue with hardware which needs delay */

	mdelay(20);



	ret = psp_v11_0_wait_for_bootloader(psp);



	return ret;

	return psp_v11_0_bootloader_load_component(psp, &psp->sys, PSP_BL__LOAD_SYSDRV);

}



static int psp_v11_0_bootloader_load_sos(struct psp_context *psp)