Commit fcaaed7c authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

staging: vchiq: drop completed tasks from TODO 



This removes all already completed tasks from the TODO file.

Reviewed-by: default avatarNicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/1642968143-19281-6-git-send-email-stefan.wahren@i2se.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3e68ebd0

drivers/staging/vc04_services/interface/TODO

+0 −29
Original line number Diff line number Diff line
@@ -16,23 +16,6 @@ some of the ones we want: 
  to manage these buffers as dmabufs so that we can zero-copy import

  camera images into vc4 for rendering/display.



* Garbage-collect unused code



One of the reasons this driver wasn't upstreamed previously was that

there's a lot code that got built that's probably unnecessary these

days.  Once we have the set of VCHI-using drivers we want in tree, we

should be able to do a sweep of the code to see what's left that's

unused.



* Make driver more portable



Building this driver with arm/multi_v7_defconfig or arm64/defconfig

leads to data corruption during the following command:



  vchiq_test -f 1



This should be fixed.



* Fix kernel module support



Even the VPU firmware doesn't support a VCHI re-connect, the driver
@@ -68,18 +51,6 @@ The code follows the 80 characters limitation yet tends to go 3 or 4 levels of 
indentation deep making it very unpleasant to read. This is specially relevant

in the character driver ioctl code and in the core thread functions.



* Reorganize file structure: Move char driver to it's own file and join both

platform files



The cdev is defined alongside with the platform code in vchiq_arm.c. It would

be nice to completely decouple it from the actual core code. For instance to be

able to use bcm2835-audio without having /dev/vchiq created. One could argue

it's better for security reasons or general cleanliness. It could even be

interesting to create two different kernel modules, something the likes of

vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process.



The code in vchiq_bcm2835_arm.c should fit in the generic platform file.



* Get rid of all non essential global structures and create a proper per

device structure