Commit fb855768 authored by Tomer Tayar's avatar Tomer Tayar Committed by Oded Gabbay
Browse files

habanalabs: fix calculation of DRAM base address in PCIe BAR 



The calculation of the device DRAM base address before setting the
relevant PCIe BAR to point at it, has an assumption that this BAR is
used to access only the DRAM, and thus the covered DRAM size is a power
of 2.
In future ASICs it is not necessarily true, so need to update the
calculation to support also a non-power-of-2 size.

Signed-off-by: default avatarTomer Tayar <ttayar@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 46e49f43

drivers/misc/habanalabs/common/device.c

+5 −1
Original line number Diff line number Diff line
@@ -42,7 +42,11 @@ static uint64_t hl_set_dram_bar(struct hl_device *hdev, u64 addr) 
	struct asic_fixed_properties *prop = &hdev->asic_prop;

	u64 bar_base_addr;



	if (is_power_of_2(prop->dram_pci_bar_size))

		bar_base_addr = addr & ~(prop->dram_pci_bar_size - 0x1ull);

	else

		bar_base_addr = DIV_ROUND_DOWN_ULL(addr, prop->dram_pci_bar_size) *

				prop->dram_pci_bar_size;



	return hdev->asic_funcs->set_dram_bar_base(hdev, bar_base_addr);

}