Commit fb637265 authored Apr 27, 2021 by Fabio M. De Francesco Committed by Alex Deucher May 10, 2021

drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all with drm_modeset_lock



drm_modeset_lock_all() is not needed here, so it is replaced with
drm_modeset_lock(). The crtc list around which we are looping never
changes, therefore the only lock we need is to protect access to
crtc->state.

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 2b24c199

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -1599,16 +1599,14 @@ static int amdgpu_pmops_runtime_idle(struct device *dev)
		if (amdgpu_device_has_dc_support(adev)) {
		struct drm_crtc *crtc;

		drm_modeset_lock_all(drm_dev);

		drm_for_each_crtc(crtc, drm_dev) {
		if (crtc->state->active) {
		drm_modeset_lock(&crtc->mutex, NULL);
		if (crtc->state->active)
		ret = -EBUSY;
		drm_modeset_unlock(&crtc->mutex);
		if (ret < 0)
		break;
		}
		}

		drm_modeset_unlock_all(drm_dev);

		} else {
		struct drm_connector *list_connector;