Commit fb20995d authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio:light:jsa1212: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc 



Letting the compiler remove these functions when the kernel is built
without CONFIG_PM_SLEEP support is simpler and less error prone than the
use of #ifdef based config guards.

Removing instances of this approach from IIO also stops them being
copied into new drivers.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20220130193147.279148-23-jic23@kernel.org
parent e9b76712

drivers/iio/light/jsa1212.c

+3 −8
Original line number Diff line number Diff line
@@ -383,7 +383,6 @@ static int jsa1212_remove(struct i2c_client *client) 
	return jsa1212_power_off(data);

}



#ifdef CONFIG_PM_SLEEP

static int jsa1212_suspend(struct device *dev)

{

	struct jsa1212_data *data;
@@ -421,12 +420,8 @@ static int jsa1212_resume(struct device *dev) 
	return ret;

}



static SIMPLE_DEV_PM_OPS(jsa1212_pm_ops, jsa1212_suspend, jsa1212_resume);



#define JSA1212_PM_OPS (&jsa1212_pm_ops)

#else

#define JSA1212_PM_OPS NULL

#endif

static DEFINE_SIMPLE_DEV_PM_OPS(jsa1212_pm_ops, jsa1212_suspend,

				jsa1212_resume);



static const struct acpi_device_id jsa1212_acpi_match[] = {

	{"JSA1212", 0},
@@ -443,7 +438,7 @@ MODULE_DEVICE_TABLE(i2c, jsa1212_id); 
static struct i2c_driver jsa1212_driver = {

	.driver = {

		.name	= JSA1212_DRIVER_NAME,

		.pm	= JSA1212_PM_OPS,

		.pm	= pm_sleep_ptr(&jsa1212_pm_ops),

		.acpi_match_table = ACPI_PTR(jsa1212_acpi_match),

	},

	.probe		= jsa1212_probe,