Commit f8ab27d9 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: esp_scsi: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-32-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 52e65d1c

drivers/scsi/esp_scsi.c

+4 −6
Original line number Diff line number Diff line
@@ -936,7 +936,7 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent, 
		}

	}



	cmd->scsi_done(cmd);

	scsi_done(cmd);



	list_del(&ent->list);

	esp_put_ent(esp, ent);
@@ -965,8 +965,6 @@ static int esp_queuecommand_lck(struct scsi_cmnd *cmd, void (*done)(struct scsi_ 


	ent->cmd = cmd;



	cmd->scsi_done = done;



	spriv = ESP_CMD_PRIV(cmd);

	spriv->num_sg = 0;
@@ -2038,7 +2036,7 @@ static void esp_reset_cleanup_one(struct esp *esp, struct esp_cmd_entry *ent) 
	if (ent->flags & ESP_CMD_FLAG_AUTOSENSE)

		esp_unmap_sense(esp, ent);



	cmd->scsi_done(cmd);

	scsi_done(cmd);

	list_del(&ent->list);

	esp_put_ent(esp, ent);

}
@@ -2061,7 +2059,7 @@ static void esp_reset_cleanup(struct esp *esp) 


		list_del(&ent->list);

		cmd->result = DID_RESET << 16;

		cmd->scsi_done(cmd);

		scsi_done(cmd);

		esp_put_ent(esp, ent);

	}
@@ -2535,7 +2533,7 @@ static int esp_eh_abort_handler(struct scsi_cmnd *cmd) 
		list_del(&ent->list);



		cmd->result = DID_ABORT << 16;

		cmd->scsi_done(cmd);

		scsi_done(cmd);



		esp_put_ent(esp, ent);