Commit f6dbe38e authored by Bryant G. Ly's avatar Bryant G. Ly Committed by Martin K. Petersen
Browse files

scsi: ibmvscsis: Fixed a bug reported by Dan Carpenter 



SUPPORTED_FORMATS is 1 << 1 so it's never zero.

Signed-off-by: default avatarBryant G. Ly <bryantly@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Cyr <mikecyr@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 81290215

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c

+1 −1
Original line number Diff line number Diff line
@@ -1978,7 +1978,7 @@ static long ibmvscsis_srp_login(struct scsi_info *vscsi, 
		reason = SRP_LOGIN_REJ_MULTI_CHANNEL_UNSUPPORTED;

	else if (fmt->buffers & (~SUPPORTED_FORMATS))

		reason = SRP_LOGIN_REJ_UNSUPPORTED_DESCRIPTOR_FMT;

	else if ((fmt->buffers | SUPPORTED_FORMATS) == 0)

	else if ((fmt->buffers & SUPPORTED_FORMATS) == 0)

		reason = SRP_LOGIN_REJ_UNSUPPORTED_DESCRIPTOR_FMT;



	if (vscsi->state == SRP_PROCESSING)