Commit f63ed6cf authored by Xiaoke Wang's avatar Xiaoke Wang Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: add kfree() on an error path of rtw_xmit_resource_alloc() 



In rtw_xmit_resource_alloc(), if usb_alloc_urb() fails, then the memory
`pxmitbuf->pallocated_buf` which is allocated by kzalloc() is not properly
released before returning.
So this patch adds kfree() on the above error path to release it in time.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Reviewed-by: default avatarMartin Kaiser <martin@kaiser.cx>
Signed-off-by: default avatarXiaoke Wang <xkernel.wang@foxmail.com>
Link: https://lore.kernel.org/r/tencent_3B46EE3287288555389AD2EC3F388827B306@qq.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 00def639

drivers/staging/r8188eu/core/rtw_xmit.c

+3 −1
Original line number Diff line number Diff line
@@ -44,8 +44,10 @@ static int rtw_xmit_resource_alloc(struct adapter *padapter, struct xmit_buf *px 
	pxmitbuf->dma_transfer_addr = 0;



	pxmitbuf->pxmit_urb = usb_alloc_urb(0, GFP_KERNEL);

	if (!pxmitbuf->pxmit_urb)

	if (!pxmitbuf->pxmit_urb) {

		kfree(pxmitbuf->pallocated_buf);

		return _FAIL;

	}



	return _SUCCESS;

}