Unverified Commit f496647e authored by Wedson Almeida Filho's avatar Wedson Almeida Filho Committed by Christian Brauner
Browse files

nfs: move nfs4_xattr_handlers to .rodata 



This makes it harder for accidental or malicious changes to
nfs4_xattr_handlers at runtime.

Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org
Signed-off-by: default avatarWedson Almeida Filho <walmeida@microsoft.com>
Link: https://lore.kernel.org/r/20230930050033.41174-19-wedsonaf@gmail.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent ffb2e065

fs/nfs/nfs.h

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ struct nfs_subversion { 
	const struct rpc_version *rpc_vers;	/* NFS version information */

	const struct nfs_rpc_ops *rpc_ops;	/* NFS operations */

	const struct super_operations *sops;	/* NFS Super operations */

	const struct xattr_handler **xattr;	/* NFS xattr handlers */

	const struct xattr_handler * const *xattr;	/* NFS xattr handlers */

	struct list_head list;		/* List of NFS versions */

};

fs/nfs/nfs4_fs.h

+1 −1
Original line number Diff line number Diff line
@@ -315,7 +315,7 @@ extern struct rpc_clnt *nfs4_proc_lookup_mountpoint(struct inode *, 
						    struct nfs_fh *,

						    struct nfs_fattr *);

extern int nfs4_proc_secinfo(struct inode *, const struct qstr *, struct nfs4_secinfo_flavors *);

extern const struct xattr_handler *nfs4_xattr_handlers[];

extern const struct xattr_handler * const nfs4_xattr_handlers[];

extern int nfs4_set_rw_stateid(nfs4_stateid *stateid,

		const struct nfs_open_context *ctx,

		const struct nfs_lock_context *l_ctx,

fs/nfs/nfs4proc.c

+1 −1
Original line number Diff line number Diff line
@@ -10733,7 +10733,7 @@ static const struct xattr_handler nfs4_xattr_nfs4_user_handler = { 
};

#endif



const struct xattr_handler *nfs4_xattr_handlers[] = {

const struct xattr_handler * const nfs4_xattr_handlers[] = {

	&nfs4_xattr_nfs4_acl_handler,

#if defined(CONFIG_NFS_V4_1)

	&nfs4_xattr_nfs4_dacl_handler,