Commit f40849b8 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Greg Kroah-Hartman
Browse files

usb-misc: sisusbvga: Remove memory allocation logs 



This patch remove three calls to dev_err() from sisusb_probe() as
reporting memory allocation failures is redundant:

 - Remove a call to dev_err() that was reporting unsuccesful call to
   kzalloc().

 - Remove two calls to dev_err() that were reporting unsuccesful calls
   to kmalloc().

One call to dev_err() reporting memory allocation is left unchanged as
the last patch of the series removes it.

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@collabora.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8a102fd6

drivers/usb/misc/sisusbvga/sisusb.c

+2 −5
Original line number Diff line number Diff line
@@ -3036,10 +3036,9 @@ static int sisusb_probe(struct usb_interface *intf, 


	/* Allocate memory for our private */

	sisusb = kzalloc(sizeof(*sisusb), GFP_KERNEL);

	if (!sisusb) {

		dev_err(&dev->dev, "Failed to allocate memory for private data\n");

	if (!sisusb)

		return -ENOMEM;

	}



	kref_init(&sisusb->kref);



	mutex_init(&(sisusb->lock));
@@ -3066,7 +3065,6 @@ static int sisusb_probe(struct usb_interface *intf, 
	sisusb->ibufsize = SISUSB_IBUF_SIZE;

	sisusb->ibuf = kmalloc(SISUSB_IBUF_SIZE, GFP_KERNEL);

	if (!sisusb->ibuf) {

		dev_err(&sisusb->sisusb_dev->dev, "Failed to allocate memory for input buffer");

		retval = -ENOMEM;

		goto error_2;

	}
@@ -3077,7 +3075,6 @@ static int sisusb_probe(struct usb_interface *intf, 
		sisusb->obuf[i] = kmalloc(SISUSB_OBUF_SIZE, GFP_KERNEL);

		if (!sisusb->obuf[i]) {

			if (i == 0) {

				dev_err(&sisusb->sisusb_dev->dev, "Failed to allocate memory for output buffer\n");

				retval = -ENOMEM;

				goto error_3;

			}