Commit f3c05201 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Michael Ellerman
Browse files

powerpc/mm: ptdump: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200209105901.1620958-4-gregkh@linuxfoundation.org
parent 08f6a797

arch/powerpc/mm/ptdump/bats.c

+3 −5
Original line number Diff line number Diff line
@@ -164,10 +164,8 @@ static const struct file_operations bats_fops = { 


static int __init bats_init(void)

{

	struct dentry *debugfs_file;



	debugfs_file = debugfs_create_file("block_address_translation", 0400,

	debugfs_create_file("block_address_translation", 0400,

			    powerpc_debugfs_root, NULL, &bats_fops);

	return debugfs_file ? 0 : -ENOMEM;

	return 0;

}

device_initcall(bats_init);

arch/powerpc/mm/ptdump/hashpagetable.c

+2 −5
Original line number Diff line number Diff line
@@ -527,13 +527,10 @@ static const struct file_operations ptdump_fops = { 


static int ptdump_init(void)

{

	struct dentry *debugfs_file;



	if (!radix_enabled()) {

		populate_markers();

		debugfs_file = debugfs_create_file("kernel_hash_pagetable",

				0400, NULL, NULL, &ptdump_fops);

		return debugfs_file ? 0 : -ENOMEM;

		debugfs_create_file("kernel_hash_pagetable", 0400, NULL, NULL,

				    &ptdump_fops);

	}

	return 0;

}

arch/powerpc/mm/ptdump/ptdump.c

+3 −5
Original line number Diff line number Diff line
@@ -417,12 +417,10 @@ void ptdump_check_wx(void) 


static int ptdump_init(void)

{

	struct dentry *debugfs_file;



	populate_markers();

	build_pgtable_complete_mask();

	debugfs_file = debugfs_create_file("kernel_page_tables", 0400, NULL,

			NULL, &ptdump_fops);

	return debugfs_file ? 0 : -ENOMEM;

	debugfs_create_file("kernel_page_tables", 0400, NULL, NULL,

			    &ptdump_fops);

	return 0;

}

device_initcall(ptdump_init);

arch/powerpc/mm/ptdump/segment_regs.c

+3 −5
Original line number Diff line number Diff line
@@ -55,10 +55,8 @@ static const struct file_operations sr_fops = { 


static int __init sr_init(void)

{

	struct dentry *debugfs_file;



	debugfs_file = debugfs_create_file("segment_registers", 0400,

					   powerpc_debugfs_root, NULL, &sr_fops);

	return debugfs_file ? 0 : -ENOMEM;

	debugfs_create_file("segment_registers", 0400, powerpc_debugfs_root,

			    NULL, &sr_fops);

	return 0;

}

device_initcall(sr_init);