Commit f3b9db5f authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Damien Le Moal
Browse files

ata: libata: remove pointless debugging messages 



Debugging messages in pci init functions or sg setup are pretty
much pointless, as the workflow pretty much decides what happened.
So drop them.

Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent da299470

drivers/ata/acard-ahci.c

+0 −4
Original line number Diff line number Diff line
@@ -185,8 +185,6 @@ static unsigned int acard_ahci_fill_sg(struct ata_queued_cmd *qc, void *cmd_tbl) 
	struct acard_sg *acard_sg = cmd_tbl + AHCI_CMD_TBL_HDR_SZ;

	unsigned int si, last_si = 0;



	VPRINTK("ENTER\n");



	/*

	 * Next, the S/G list.

	 */
@@ -362,8 +360,6 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id 
	struct ata_host *host;

	int n_ports, i, rc;



	VPRINTK("ENTER\n");



	WARN_ON((int)ATA_MAX_QUEUE > AHCI_MAX_CMDS);



	ata_print_version_once(&pdev->dev, DRV_VERSION);

drivers/ata/ahci.c

+0 −2
Original line number Diff line number Diff line
@@ -1673,8 +1673,6 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 
	int n_ports, i, rc;

	int ahci_pci_bar = AHCI_PCI_BAR_STANDARD;



	VPRINTK("ENTER\n");



	WARN_ON((int)ATA_MAX_QUEUE > AHCI_MAX_CMDS);



	ata_print_version_once(&pdev->dev, DRV_VERSION);

drivers/ata/ata_piix.c

+0 −3
Original line number Diff line number Diff line
@@ -1345,7 +1345,6 @@ static void piix_init_pcs(struct ata_host *host, 
	new_pcs = pcs | map_db->port_enable;



	if (new_pcs != pcs) {

		DPRINTK("updating PCS from 0x%x to 0x%x\n", pcs, new_pcs);

		pci_write_config_word(pdev, ICH5_PCS, new_pcs);

		msleep(150);

	}
@@ -1769,14 +1768,12 @@ static int __init piix_init(void) 
{

	int rc;



	DPRINTK("pci_register_driver\n");

	rc = pci_register_driver(&piix_pci_driver);

	if (rc)

		return rc;



	in_module_init = 0;



	DPRINTK("done\n");

	return 0;

}

drivers/ata/libahci.c

+0 −3
Original line number Diff line number Diff line
@@ -1620,8 +1620,6 @@ static unsigned int ahci_fill_sg(struct ata_queued_cmd *qc, void *cmd_tbl) 
	struct ahci_sg *ahci_sg = cmd_tbl + AHCI_CMD_TBL_HDR_SZ;

	unsigned int si;



	VPRINTK("ENTER\n");



	/*

	 * Next, the S/G list.

	 */
@@ -1695,7 +1693,6 @@ static void ahci_fbs_dec_intr(struct ata_port *ap) 
	u32 fbs = readl(port_mmio + PORT_FBS);

	int retries = 3;



	DPRINTK("ENTER\n");

	BUG_ON(!pp->fbs_enabled);



	/* time to wait for DEC is not specified by AHCI spec,

drivers/ata/libata-core.c

+0 −11
Original line number Diff line number Diff line
@@ -764,9 +764,6 @@ int ata_build_rw_tf(struct ata_taskfile *tf, struct ata_device *dev, 
		head  = track % dev->heads;

		sect  = (u32)block % dev->sectors + 1;



		DPRINTK("block %u track %u cyl %u head %u sect %u\n",

			(u32)block, track, cyl, head, sect);



		/* Check whether the converted CHS can fit.

		   Cylinder: 0-65535

		   Head: 0-15
@@ -4569,8 +4566,6 @@ static int ata_sg_setup(struct ata_queued_cmd *qc) 
	struct ata_port *ap = qc->ap;

	unsigned int n_elem;



	VPRINTK("ENTER, ata%u\n", ap->print_id);



	n_elem = dma_map_sg(ap->dev, qc->sg, qc->n_elem, qc->dma_dir);

	if (n_elem < 1)

		return -1;
@@ -5375,8 +5370,6 @@ struct ata_port *ata_port_alloc(struct ata_host *host) 
{

	struct ata_port *ap;



	DPRINTK("ENTER\n");



	ap = kzalloc(sizeof(*ap), GFP_KERNEL);

	if (!ap)

		return NULL;
@@ -5493,8 +5486,6 @@ struct ata_host *ata_host_alloc(struct device *dev, int max_ports) 
	int i;

	void *dr;



	DPRINTK("ENTER\n");



	/* alloc a container for our list of ATA ports (buses) */

	sz = sizeof(struct ata_host) + (max_ports + 1) * sizeof(void *);

	host = kzalloc(sz, GFP_KERNEL);
@@ -5784,9 +5775,7 @@ int ata_port_probe(struct ata_port *ap) 
		__ata_port_probe(ap);

		ata_port_wait_eh(ap);

	} else {

		DPRINTK("ata%u: bus probe begin\n", ap->print_id);

		rc = ata_bus_probe(ap);

		DPRINTK("ata%u: bus probe end\n", ap->print_id);

	}

	return rc;

}