Commit f3a23c2c authored Feb 01, 2021 by Lee Jones Committed by Jens Axboe Mar 12, 2021

ata: sata_mv: Fix worthy headers and demote others

Fixes the following W=1 kernel build warning(s):

drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'ap' not described in 'mv_start_edma'
drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'port_mmio' not described in 'mv_start_edma'
drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'protocol' not described in 'mv_start_edma'
drivers/ata/sata_mv.c:1162: warning: Excess function parameter 'base' description in 'mv_start_edma'
drivers/ata/sata_mv.c:1535: warning: Function parameter or member 'enable_bmdma' not described in 'mv_bmdma_enable_iie'
drivers/ata/sata_mv.c:1535: warning: expecting prototype for mv_bmdma_enable(). Prototype was for mv_bmdma_enable_iie() instead
drivers/ata/sata_mv.c:1930: warning: Function parameter or member 'ap' not described in 'mv_bmdma_stop_ap'
drivers/ata/sata_mv.c:1930: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead
drivers/ata/sata_mv.c:2228: warning: Function parameter or member 'ap' not described in 'mv_send_fis'
drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'hpriv' not described in 'mv6_reset_hc'
drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'n_hc' not described in 'mv6_reset_hc'
drivers/ata/sata_mv.c:3541: warning: Function parameter or member 'hpriv' not described in 'soc_is_65n'
drivers/ata/sata_mv.c:3541: warning: expecting prototype for soc_is_65(). Prototype was for soc_is_65n() instead

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Mark Lord <mlord@pobox.com>
Cc: ALWAYS copy <linux-ide@vger.kernel.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 6864e781

drivers/ata/sata_mv.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -1146,9 +1146,8 @@ static void mv_set_irq_coalescing(struct ata_host *host,
		spin_unlock_irqrestore(&host->lock, flags);
		}

		/**
		/*
		* mv_start_edma - Enable eDMA engine
		* @base: port base address
		* @pp: port private data
		*
		* Verify the local cache of the eDMA state is accurate with a
		@@ -1519,7 +1518,7 @@ static void mv_60x1_errata_sata25(struct ata_port *ap, int want_ncq)
		writel(new, hpriv->base + GPIO_PORT_CTL);
		}

		/**
		/*
		* mv_bmdma_enable - set a magic bit on GEN_IIE to allow bmdma
		* @ap: Port being initialized
		*
		@@ -1919,7 +1918,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc)

		/**
		* mv_bmdma_stop - Stop BMDMA transfer
		* @qc: queued command to stop DMA on.
		* @ap: port to stop
		*
		* Clears the ATA_DMA_START flag in the bmdma control register
		*
		@@ -2221,6 +2220,7 @@ static u8 mv_sff_check_status(struct ata_port *ap)

		/**
		* mv_send_fis - Send a FIS, using the "Vendor-Unique FIS" register
		* @ap: ATA port to send a FIS
		* @fis: fis to be sent
		* @nwords: number of 32-bit words in the fis
		*/
		@@ -3249,7 +3249,7 @@ static void mv6_reset_flash(struct mv_host_priv hpriv, void __iomem mmio)
		writel(tmp, mmio + GPIO_PORT_CTL);
		}

		/**
		/*
		* mv6_reset_hc - Perform the 6xxx global soft reset
		* @mmio: base address of the HBA
		*
		@@ -3530,7 +3530,7 @@ static void mv_soc_65n_phy_errata(struct mv_host_priv *hpriv,
		writel(reg, port_mmio + PHY_MODE9_GEN1);
		}

		/**
		/*
		* soc_is_65 - check if the soc is 65 nano device
		*
		* Detect the type of the SoC, this is done by reading the PHYCFG_OFS