Commit f32e5616 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: parisc: Drop superfluous PCM preallocation error checks 



snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e6e8c82b

sound/parisc/harmony.c

+2 −8
Original line number Diff line number Diff line
@@ -669,14 +669,8 @@ snd_harmony_pcm_init(struct snd_harmony *h) 
	}



	/* pre-allocate space for DMA */

	err = snd_pcm_lib_preallocate_pages_for_all(pcm, h->dma.type,

						    h->dma.dev,

						    MAX_BUF_SIZE, 

						    MAX_BUF_SIZE);

	if (err < 0) {

		printk(KERN_ERR PFX "buffer allocation error: %d\n", err);

		return err;

	}

	snd_pcm_lib_preallocate_pages_for_all(pcm, h->dma.type, h->dma.dev,

					      MAX_BUF_SIZE, MAX_BUF_SIZE);



	h->st.format = snd_harmony_set_data_format(h,

		SNDRV_PCM_FORMAT_S16_BE, 1);