Commit f30785db authored by Ye Bin's avatar Ye Bin Committed by Martin K. Petersen
Browse files

scsi: core: Add missing scsi_device_put() in scsi_host_block() 

The scsi_host_block() case was missing in commit 4dea170f ("scsi: core:
Fix incorrect usage of shost_for_each_device").

Link: https://lore.kernel.org/r/20200717090921.29243-1-yebin10@huawei.com


Fixes: 2bb95584 ("scsi: core: add scsi_host_(block,unblock) helper function")
Fixes: 4dea170f ("scsi: core: Fix incorrect usage of shost_for_each_device")
Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e73a5e8e

drivers/scsi/scsi_lib.c

+3 −1
Original line number Diff line number Diff line
@@ -2819,9 +2819,11 @@ scsi_host_block(struct Scsi_Host *shost) 
		mutex_lock(&sdev->state_mutex);

		ret = scsi_internal_device_block_nowait(sdev);

		mutex_unlock(&sdev->state_mutex);

		if (ret)

		if (ret) {

			scsi_device_put(sdev);

			break;

		}

	}



	/*

	 * SCSI never enables blk-mq's BLK_MQ_F_BLOCKING flag so