Commit f0f17bed authored by Luca Ceresoli's avatar Luca Ceresoli Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: remove useless variable rtw_AcceptAddbaReq 



rtw_AcceptAddbaReq is a static variable, it is set once and never
modified. It is referenced only once, to assign its value to a member
of struct registry_priv with practically the same name.

Get rid of the variable, and move the meaningful part of the comment
near the declaration of the relevant field of struct registry_priv.

Raises a new checkpatch issue, which is fixed in a later commit:
  CHECK: Avoid CamelCase: <bAcceptAddbaReq>

Signed-off-by: default avatarLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32986254

drivers/staging/rtl8188eu/include/drv_types.h

+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ struct registry_priv { 
	u8	wifi_spec;/*  !turbo_mode */



	u8	channel_plan;

	bool	bAcceptAddbaReq;

	bool	bAcceptAddbaReq; /* true = accept AP's Add BA req */



	u8	antdiv_cfg;

	u8	antdiv_type;

drivers/staging/rtl8188eu/os_dep/os_intfs.c

+1 −3
Original line number Diff line number Diff line
@@ -101,8 +101,6 @@ static int rtw_rf_config = RF_819X_MAX_TYPE; /* auto */ 
static int rtw_low_power;

static int rtw_wifi_spec;

static int rtw_channel_plan = RT_CHANNEL_DOMAIN_MAX;

/* 0:Reject AP's Add BA req, 1:Accept AP's Add BA req. */

static int rtw_AcceptAddbaReq = true;



static int rtw_antdiv_cfg = 2; /*  0:OFF , 1:ON, 2:decide by Efuse config */
@@ -593,7 +591,7 @@ static void loadparam(struct adapter *padapter, struct net_device *pnetdev) 
	registry_par->low_power = (u8)rtw_low_power;

	registry_par->wifi_spec = (u8)rtw_wifi_spec;

	registry_par->channel_plan = (u8)rtw_channel_plan;

	registry_par->bAcceptAddbaReq = (u8)rtw_AcceptAddbaReq;

	registry_par->bAcceptAddbaReq = true;

	registry_par->antdiv_cfg = (u8)rtw_antdiv_cfg;

	registry_par->antdiv_type = (u8)rtw_antdiv_type;

	registry_par->hwpdn_mode = (u8)rtw_hwpdn_mode;