Commit f0cc82ca authored by Justin Stitt's avatar Justin Stitt Committed by Leon Romanovsky
Browse files

RDMA/irdma: Replace deprecated strncpy 

`strncpy` is deprecated for use on NUL-terminated destination strings [1]
and as such we should prefer more robust and less ambiguous string
interfaces.

A suitable replacement is `strscpy_pad` due to the fact that it
guarantees NUL-termination on the destination buffer.

It is unclear to me whether `i40iw_client.name` requires NUL-padding but
have opted to keep the NUL-padding behavior that strncpy provides to
ensure no functional change.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://github.com/KSPP/linux/issues/90


Cc: linux-hardening@vger.kernel.org
Signed-off-by: default avatarJustin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20230921-strncpy-drivers-infiniband-hw-irdma-i40iw_if-c-v1-1-22d87aef7186@google.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 58c49c09

drivers/infiniband/hw/irdma/i40iw_if.c

+1 −1
Original line number Diff line number Diff line
@@ -186,7 +186,7 @@ static int i40iw_probe(struct auxiliary_device *aux_dev, const struct auxiliary_ 
							       aux_dev);

	struct i40e_info *cdev_info = i40e_adev->ldev;



	strncpy(i40iw_client.name, "irdma", I40E_CLIENT_STR_LENGTH);

	strscpy_pad(i40iw_client.name, "irdma", I40E_CLIENT_STR_LENGTH);

	i40e_client_device_register(cdev_info, &i40iw_client);



	return 0;