Commit ef425202 authored by Nikita Zhandarovich's avatar Nikita Zhandarovich Committed by Leon Romanovsky
Browse files

RDMA/cxgb4: add null-ptr-check after ip_dev_find() 



ip_dev_find() may return NULL and assign it to pdev which is
dereferenced later.
Fix this by checking the return value of ip_dev_find() for NULL
similar to the way it is done with other instances of said function.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1cab775c ("RDMA/cxgb4: Fix LE hash collision bug for passive open connection")
Signed-off-by: default avatarNikita Zhandarovich <n.zhandarovich@fintech.ru>
Link: https://lore.kernel.org/r/20230201172103.17261-1-n.zhandarovich@fintech.ru


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 62712228

drivers/infiniband/hw/cxgb4/cm.c

+4 −0
Original line number Diff line number Diff line
@@ -4144,6 +4144,10 @@ static int rx_pkt(struct c4iw_dev *dev, struct sk_buff *skb) 


	if (neigh->dev->flags & IFF_LOOPBACK) {

		pdev = ip_dev_find(&init_net, iph->daddr);

		if (!pdev) {

			pr_err("%s - failed to find device!\n", __func__);

			goto free_dst;

		}

		e = cxgb4_l2t_get(dev->rdev.lldi.l2t, neigh,

				    pdev, 0);

		pi = (struct port_info *)netdev_priv(pdev);