Commit eb5a3e3b authored by Qiheng Lin's avatar Qiheng Lin Committed by Martin K. Petersen
Browse files

scsi: qla4xxx: Remove unneeded if-null-free check 

Eliminate the following coccicheck warning:

drivers/scsi/qla4xxx/ql4_os.c:4175:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:4196:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:4215:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:6400:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:6402:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:6555:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:6557:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:7838:2-7: WARNING:
 NULL check before some freeing functions is not needed.
drivers/scsi/qla4xxx/ql4_os.c:7840:2-7: WARNING:
 NULL check before some freeing functions is not needed.

Link: https://lore.kernel.org/r/20210409120345.6447-1-linqiheng@huawei.com


Signed-off-by: default avatarQiheng Lin <linqiheng@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5dc34688

drivers/scsi/qla4xxx/ql4_os.c

+9 −18
Original line number Diff line number Diff line
@@ -4171,7 +4171,6 @@ static void qla4xxx_mem_free(struct scsi_qla_host *ha) 
		dma_free_coherent(&ha->pdev->dev, ha->queues_len, ha->queues,

				  ha->queues_dma);



	if (ha->fw_dump)

	vfree(ha->fw_dump);



	ha->queues_len = 0;
@@ -4192,7 +4191,6 @@ static void qla4xxx_mem_free(struct scsi_qla_host *ha) 


	dma_pool_destroy(ha->chap_dma_pool);



	if (ha->chap_list)

	vfree(ha->chap_list);

	ha->chap_list = NULL;
@@ -4211,7 +4209,6 @@ static void qla4xxx_mem_free(struct scsi_qla_host *ha) 
		iounmap(ha->reg);

	}



	if (ha->reset_tmplt.buff)

	vfree(ha->reset_tmplt.buff);



	pci_release_regions(ha->pdev);
@@ -6396,9 +6393,7 @@ static int qla4xxx_is_session_exists(struct scsi_qla_host *ha, 
	}



exit_check:

	if (fw_tddb)

	vfree(fw_tddb);

	if (tmp_tddb)

	vfree(tmp_tddb);

	return ret;

}
@@ -6551,9 +6546,7 @@ static int qla4xxx_is_flash_ddb_exists(struct scsi_qla_host *ha, 
	}



exit_check:

	if (fw_tddb)

	vfree(fw_tddb);

	if (tmp_tddb)

	vfree(tmp_tddb);

	return ret;

}
@@ -7834,9 +7827,7 @@ static int qla4xxx_sysfs_ddb_logout(struct iscsi_bus_flash_session *fnode_sess, 
		ret = -ESRCH;



exit_ddb_logout:

	if (flash_tddb)

	vfree(flash_tddb);

	if (tmp_tddb)

	vfree(tmp_tddb);

	if (fw_ddb_entry)

		dma_pool_free(ha->fw_ddb_dma_pool, fw_ddb_entry, fw_ddb_dma);