Commit eaf05e82 authored by Neal Liu's avatar Neal Liu Committed by Herbert Xu
Browse files

crypto: aspeed - fix type warnings 



This patch fixes following warnings:

1. sparse: incorrect type in assignment (different base types)
Fix: change to __le32 type.
2. sparse: cast removes address space '__iomem' of expression
Fix: use readb to avoid dereferencing the memory.

Signed-off-by: default avatarNeal Liu <neal_liu@aspeedtech.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent acd4045d

drivers/crypto/aspeed/aspeed-acry.c

+4 −4
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, 
				    enum aspeed_rsa_key_mode mode)

{

	const u8 *src = xbuf;

	u32 *dw_buf = (u32 *)buf;

	__le32 *dw_buf = buf;

	int nbits, ndw;

	int i, j, idx;

	u32 data = 0;
@@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, 
static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)

{

	struct akcipher_request *req = acry_dev->req;

	u8 *sram_buffer = (u8 *)acry_dev->acry_sram;

	u8 __iomem *sram_buffer = acry_dev->acry_sram;

	struct scatterlist *out_sg = req->dst;

	static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN];

	int leading_zero = 1;
@@ -321,11 +321,11 @@ static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) 


	for (j = ASPEED_ACRY_SRAM_MAX_LEN - 1; j >= 0; j--) {

		data_idx = acry_dev->data_byte_mapping[j];

		if (sram_buffer[data_idx] == 0 && leading_zero) {

		if (readb(sram_buffer + data_idx) == 0 && leading_zero) {

			result_nbytes--;

		} else {

			leading_zero = 0;

			dram_buffer[i] = sram_buffer[data_idx];

			dram_buffer[i] = readb(sram_buffer + data_idx);

			i++;

		}

	}