Commit ea7d5e7b authored by Ohad Sharabi's avatar Ohad Sharabi Committed by Oded Gabbay
Browse files

habanalabs: avoid using uninitialized pointer 



When attempting to read FW component's version we should break if input
FW component is invalid in order to avoid using uninitialized
destination pointer.

Signed-off-by: default avatarOhad Sharabi <osharabi@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 6542c354

drivers/misc/habanalabs/common/firmware_if.c

+1 −0
Original line number Diff line number Diff line
@@ -1566,6 +1566,7 @@ static void hl_fw_dynamic_read_device_fw_version(struct hl_device *hdev, 
		break;

	default:

		dev_warn(hdev->dev, "Undefined FW component: %d\n", fwc);

		return;

	}



	strscpy(dest, fw_version, VERSION_MAX_LEN);