Commit e9c195aa authored by Chengfeng Ye's avatar Chengfeng Ye Committed by Herbert Xu
Browse files

crypto: qce - fix uaf on qce_skcipher_register_one 



Pointer alg points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing alg before free tmpl.

Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: default avatarChengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: default avatarThara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b4cb4d31

drivers/crypto/qce/skcipher.c

+1 −1
Original line number Diff line number Diff line
@@ -484,8 +484,8 @@ static int qce_skcipher_register_one(const struct qce_skcipher_def *def, 


	ret = crypto_register_skcipher(alg);

	if (ret) {

		kfree(tmpl);

		dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name);

		kfree(tmpl);

		return ret;

	}