Commit e5bb88e9 authored by Mika Westerberg's avatar Mika Westerberg
Browse files

thunderbolt: Do not program path HopIDs for USB4 routers 



These fields are marked read-only for USB4 routers so do not touch them
in that case. Update the kernel-doc of tb_dp_port_set_hops() to reflect
this too.

Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 6cb27a04

drivers/thunderbolt/switch.c

+6 −1
Original line number Diff line number Diff line
@@ -1322,7 +1322,9 @@ int tb_dp_port_hpd_clear(struct tb_port *port) 
 * @aux_tx: AUX TX Hop ID

 * @aux_rx: AUX RX Hop ID

 *

 * Programs specified Hop IDs for DP IN/OUT port.

 * Programs specified Hop IDs for DP IN/OUT port. Can be called for USB4

 * router DP adapters too but does not program the values as the fields

 * are read-only.

 */

int tb_dp_port_set_hops(struct tb_port *port, unsigned int video,

			unsigned int aux_tx, unsigned int aux_rx)
@@ -1330,6 +1332,9 @@ int tb_dp_port_set_hops(struct tb_port *port, unsigned int video, 
	u32 data[2];

	int ret;



	if (tb_switch_is_usb4(port->sw))

		return 0;



	ret = tb_port_read(port, data, TB_CFG_PORT,

			   port->cap_adap + ADP_DP_CS_0, ARRAY_SIZE(data));

	if (ret)