Commit e4cdd25c authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

tty: mxser: remove redundant assignment to hwid 



The variable hwid is assigned a value but it is never read. The
assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/tty/mxser.c:401:7: warning: Although the value stored to 'hwid'
is used in the enclosing expression, the value is never actually read
from 'hwid' [deadcode.DeadStores]

Acked-by: default avatarJiri Slaby <jirislaby@kernel.org>
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220730130925.150018-1-colin.i.king@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 74b2c563

drivers/tty/mxser.c

+1 −1
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ static enum mxser_must_hwid mxser_must_get_hwid(unsigned long io) 
	oldmcr = inb(io + UART_MCR);

	outb(0, io + UART_MCR);

	mxser_set_must_xon1_value(io, 0x11);

	if ((hwid = inb(io + UART_MCR)) != 0) {

	if (inb(io + UART_MCR) != 0) {

		outb(oldmcr, io + UART_MCR);

		return MOXA_OTHER_UART;

	}