Commit e2d53d10 authored by Mukesh Sisodiya's avatar Mukesh Sisodiya Committed by Luca Coelho
Browse files

iwlwifi: yoyo: Avoid using dram data if allocation failed 



The config set TLV setting depend on dram allocation
and if allocation failed the data used in config set tlv
should not set this.
Adding the check if dram fragment is available or not.

Signed-off-by: default avatarMukesh Sisodiya <mukesh.sisodiya@intel.com>
Fixes: 1a5daead ("iwlwifi: yoyo: support for ROM usniffer")
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220204122220.44835d181528.I3e78ba29c13bbeada017fcb2a620f3552c1dfa30@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent d8d4dd26

drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c

+10 −3
Original line number Diff line number Diff line
@@ -875,11 +875,18 @@ static void iwl_dbg_tlv_apply_config(struct iwl_fw_runtime *fwrt, 
		case IWL_FW_INI_CONFIG_SET_TYPE_DBGC_DRAM_ADDR: {

			struct iwl_dbgc1_info dram_info = {};

			struct iwl_dram_data *frags = &fwrt->trans->dbg.fw_mon_ini[1].frags[0];

			__le64 dram_base_addr = cpu_to_le64(frags->physical);

			__le32 dram_size = cpu_to_le32(frags->size);

			u64  dram_addr = le64_to_cpu(dram_base_addr);

			__le64 dram_base_addr;

			__le32 dram_size;

			u64 dram_addr;

			u32 ret;



			if (!frags)

				break;



			dram_base_addr = cpu_to_le64(frags->physical);

			dram_size = cpu_to_le32(frags->size);

			dram_addr = le64_to_cpu(dram_base_addr);



			IWL_DEBUG_FW(fwrt, "WRT: dram_base_addr 0x%016llx, dram_size 0x%x\n",

				     dram_base_addr, dram_size);

			IWL_DEBUG_FW(fwrt, "WRT: config_list->addr_offset: %u\n",