Commit e1beb1d3 authored by Avi Kivity's avatar Avi Kivity
Browse files

KVM: Replace 'light_exits' stat with 'host_state_reload' 



This is a little more accurate (since it counts actual reloads, not potential
reloads), and reverses the sense of the statistic to measure a bad event like
most of the other stats (e.g. we want to minimize all counters).

Signed-off-by: default avatarAvi Kivity <avi@qumranet.com>
parent d19a9cd2

drivers/kvm/kvm.h

+1 −1
Original line number Diff line number Diff line
@@ -246,7 +246,7 @@ struct kvm_stat { 
	u32 halt_wakeup;

	u32 request_irq_exits;

	u32 irq_exits;

	u32 light_exits;

	u32 host_state_reload;

	u32 efer_reload;

};

drivers/kvm/svm.c

+1 −0
Original line number Diff line number Diff line
@@ -654,6 +654,7 @@ static void svm_vcpu_put(struct kvm_vcpu *vcpu) 
	struct vcpu_svm *svm = to_svm(vcpu);

	int i;



	++vcpu->stat.host_state_reload;

	for (i = 0; i < NR_HOST_SAVE_USER_MSRS; i++)

		wrmsrl(host_save_user_msrs[i], svm->host_user_msrs[i]);

drivers/kvm/vmx.c

+1 −0
Original line number Diff line number Diff line
@@ -463,6 +463,7 @@ static void vmx_load_host_state(struct vcpu_vmx *vmx) 
	if (!vmx->host_state.loaded)

		return;



	++vmx->vcpu.stat.host_state_reload;

	vmx->host_state.loaded = 0;

	if (vmx->host_state.fs_reload_needed)

		load_fs(vmx->host_state.fs_sel);

drivers/kvm/x86.c

+2 −4
Original line number Diff line number Diff line
@@ -60,7 +60,7 @@ struct kvm_stats_debugfs_item debugfs_entries[] = { 
	{ "halt_wakeup", STAT_OFFSET(halt_wakeup) },

	{ "request_irq", STAT_OFFSET(request_irq_exits) },

	{ "irq_exits", STAT_OFFSET(irq_exits) },

	{ "light_exits", STAT_OFFSET(light_exits) },

	{ "host_state_reload", STAT_OFFSET(host_state_reload) },

	{ "efer_reload", STAT_OFFSET(efer_reload) },

	{ NULL }

};
@@ -1988,11 +1988,9 @@ static int __vcpu_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) 
			++vcpu->stat.request_irq_exits;

			goto out;

		}

		if (!need_resched()) {

			++vcpu->stat.light_exits;

		if (!need_resched())

			goto again;

	}

	}



out:

	if (r > 0) {