Commit dfdbc55a authored by Tomer Tayar's avatar Tomer Tayar Committed by Oded Gabbay
Browse files

accel/habanalabs: always pass exported size to alloc_sgt_from_device_pages()



For Gaudi1 the exported dma-buf is always composed of a single page, and
therefore the exported size is equal to this page's size.
When calling alloc_sgt_from_device_pages(), we pass 0 as the exported
size and internally calculate it as "number of pages * page size".
This makes alloc_sgt_from_device_pages() less clear, because the
exported size parameter is not understood as a restriction on the pages'
size.
Modify to always pass the exported size explicitly.

Signed-off-by: default avatarTomer Tayar <ttayar@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 051868d9
Loading
Loading
Loading
Loading
+2 −3
Original line number Diff line number Diff line
@@ -1561,8 +1561,7 @@ static struct sg_table *alloc_sgt_from_device_pages(struct hl_device *hdev, u64
	if (!sgt)
		return ERR_PTR(-ENOMEM);

	/* remove export size restrictions in case not explicitly defined */
	cur_size_to_export = exported_size ? exported_size : (npages * page_size);
	cur_size_to_export = exported_size;

	/* If the size of each page is larger than the dma max segment size,
	 * then we can't combine pages and the number of entries in the SGL
@@ -1728,7 +1727,7 @@ static struct sg_table *hl_map_dmabuf(struct dma_buf_attachment *attachment,
						&hl_dmabuf->device_address,
						1,
						hl_dmabuf->dmabuf->size,
						0,
						hl_dmabuf->dmabuf->size,
						attachment->dev,
						dir);