Commit ddb0b34f authored Dec 10, 2009 by Julia Lawall Committed by Mauro Carvalho Chehab Dec 16, 2009

V4L/DVB (13610): uvc: Correct size given to memset

Memset should be given the size of the structure, not the size of the pointer.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
type T;
T *x;
expression E;
@@

memset(x, E, sizeof(
+ *
 x))
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 67cabf50

drivers/media/video/uvc/uvc_video.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -145,7 +145,7 @@ static int uvc_get_video_ctrl(struct uvc_streaming *stream,
		uvc_warn_once(stream->dev, UVC_WARN_MINMAX, "UVC non "
		"compliance - GET_MIN/MAX(PROBE) incorrectly "
		"supported. Enabling workaround.\n");
		memset(ctrl, 0, sizeof ctrl);
		memset(ctrl, 0, sizeof *ctrl);
		ctrl->wCompQuality = le16_to_cpup((__le16 *)data);
		ret = 0;
		goto out;