Commit dafa7317 authored Jan 03, 2011 by Russell King - ARM Linux Committed by Dan Williams Jan 04, 2011

ARM: PL08x: fix a leak when preparing TXDs



If we fail to allocate the LLI, the prep_* function will return NULL.
However, the TXD we allocated will not be placed on any list, nor
will it be freed - we'll just drop all references to it.  Make sure
we free it rather than leaking TXDs.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent bf072af4

drivers/dma/amba-pl08x.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1332,9 +1332,10 @@ static int pl08x_prep_channel_resources(struct pl08x_dma_chan *plchan,
		int ret;

		num_llis = pl08x_fill_llis_for_desc(pl08x, txd);

		if (!num_llis)
		if (!num_llis) {
		kfree(txd);
		return -EINVAL;
		}

		spin_lock_irqsave(&plchan->lock, plchan->lockflags);