Commit da16f5be authored by Zhen Lei's avatar Zhen Lei Committed by Kalle Valo
Browse files

b43: phy_n: Delete some useless TODO code 



These TODO empty code are added by
commit 9442e5b5 ("b43: N-PHY: partly implement SPUR workaround"). It's
been more than a decade now. I don't think anyone who wants to perfect
this workaround can follow this TODO tip exactly. Instead, it limits them
to new thinking. Remove it will be better.

No functional change.

By the way, this helps reduce some binary code size.
Before:
text    data    bss     dec     hex
74472   9967    0       84439   149d7

After:
text    data    bss     dec     hex
74408   9919    0       84327   14967

Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210511034203.4122-2-thunder.leizhen@huawei.com
parent 1e36f828

drivers/net/wireless/broadcom/b43/phy_n.c

+0 −47
Original line number Diff line number Diff line
@@ -4592,58 +4592,11 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev) 
{

	struct b43_phy_n *nphy = dev->phy.n;



	u8 channel = dev->phy.channel;

	int tone[2] = { 57, 58 };

	u32 noise[2] = { 0x3FF, 0x3FF };



	B43_WARN_ON(dev->phy.rev < 3);



	if (nphy->hang_avoid)

		b43_nphy_stay_in_carrier_search(dev, 1);



	if (nphy->gband_spurwar_en) {

		/* TODO: N PHY Adjust Analog Pfbw (7) */

		if (channel == 11 && b43_is_40mhz(dev)) {

			; /* TODO: N PHY Adjust Min Noise Var(2, tone, noise)*/

		} else {

			; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/

		}

		/* TODO: N PHY Adjust CRS Min Power (0x1E) */

	}



	if (nphy->aband_spurwar_en) {

		if (channel == 54) {

			tone[0] = 0x20;

			noise[0] = 0x25F;

		} else if (channel == 38 || channel == 102 || channel == 118) {

			if (0 /* FIXME */) {

				tone[0] = 0x20;

				noise[0] = 0x21F;

			} else {

				tone[0] = 0;

				noise[0] = 0;

			}

		} else if (channel == 134) {

			tone[0] = 0x20;

			noise[0] = 0x21F;

		} else if (channel == 151) {

			tone[0] = 0x10;

			noise[0] = 0x23F;

		} else if (channel == 153 || channel == 161) {

			tone[0] = 0x30;

			noise[0] = 0x23F;

		} else {

			tone[0] = 0;

			noise[0] = 0;

		}



		if (!tone[0] && !noise[0]) {

			; /* TODO: N PHY Adjust Min Noise Var(1, tone, noise)*/

		} else {

			; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/

		}

	}



	if (nphy->hang_avoid)

		b43_nphy_stay_in_carrier_search(dev, 0);

}