Commit d9fabbde authored by Drew Fustini's avatar Drew Fustini Committed by Greg Kroah-Hartman
Browse files

Staging: fbtft: add header for internal functions 

Remove extern keyword from function prototypes to suppress warning from
checkpatch.pl with --strict option: https://lkml.org/lkml/2013/7/23/422



fbtft maintainer Noralf Tronnes advised these functions are internal to
this module & suggested moving these prototypes to new internal.h file.
He also advised fbtft.h file will eventually live in include/linux/fbtft.h

Suggested-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Signed-off-by: default avatarDrew Fustini <pdp7pdp7@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 980ac4d7

drivers/staging/fbtft/fbtft-core.c

+1 −6
Original line number Diff line number Diff line
@@ -41,12 +41,7 @@ 
#include <linux/of_gpio.h>



#include "fbtft.h"



extern void fbtft_sysfs_init(struct fbtft_par *par);

extern void fbtft_sysfs_exit(struct fbtft_par *par);

extern void fbtft_expand_debug_value(unsigned long *debug);

extern int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves,

						const char *str, int size);

#include "internal.h"



static unsigned long debug;

module_param(debug, ulong, 0);

drivers/staging/fbtft/internal.h

0 → 100644
+25 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2013 Noralf Tronnes

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License as published by

 * the Free Software Foundation; either version 2 of the License, or

 * (at your option) any later version.

 *

 * This program is distributed in the hope that it will be useful,

 * but WITHOUT ANY WARRANTY; without even the implied warranty of

 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

 * GNU General Public License for more details.

 *

 */



#ifndef __LINUX_FBTFT__INTERNAL_H

#define __LINUX_FBTFT_INTERNAL_H



void fbtft_sysfs_init(struct fbtft_par *par);

void fbtft_sysfs_exit(struct fbtft_par *par);

void fbtft_expand_debug_value(unsigned long *debug);

int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves,

			  const char *str, int size);



#endif /* __LINUX_FBTFT_INTERNAL_H */