Commit d9448fa5 authored by Michael Straube's avatar Michael Straube Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: ROMVer is always zero 



The variable ROMVer in struct HAL_VERSION is set to zero and never
changed. Remove it and replace its use with zero.

Signed-off-by: default avatarMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220407192819.10661-4-straube.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8fd86c6b

drivers/staging/r8188eu/hal/hal_com.c

+1 −1
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ void dump_chip_info(struct HAL_VERSION chip_vers) 


	cnt += sprintf((buf + cnt), "1T1R_");



	cnt += sprintf((buf + cnt), "RomVer(%d)\n", chip_vers.ROMVer);

	cnt += sprintf((buf + cnt), "RomVer(%d)\n", 0);



	pr_info("%s", buf);

}

drivers/staging/r8188eu/hal/rtl8188e_hal_init.c

+0 −1
Original line number Diff line number Diff line
@@ -505,7 +505,6 @@ void rtl8188e_read_chip_version(struct adapter *padapter) 


	ChipVersion.VendorType = ((value32 & VENDOR_ID) ? CHIP_VENDOR_UMC : CHIP_VENDOR_TSMC);

	ChipVersion.CUTVersion = (value32 & CHIP_VER_RTL_MASK) >> CHIP_VER_RTL_SHIFT; /*  IC version (CUT) */

	ChipVersion.ROMVer = 0;	/*  ROM code version. */



	dump_chip_info(ChipVersion);

drivers/staging/r8188eu/include/HalVerDef.h

+0 −1
Original line number Diff line number Diff line
@@ -25,7 +25,6 @@ struct HAL_VERSION { 
	enum HAL_CHIP_TYPE	ChipType;

	enum HAL_CUT_VERSION	CUTVersion;

	enum HAL_VENDOR		VendorType;

	u8			ROMVer;

};



/*  Get element */