Commit d7a407bc authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Steven Price
Browse files

drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname() 



It is not possible for platform_get_irq_byname() to return 0.
Use the return value from platform_get_irq_byname().

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803040401.3067484-2-ruanjinjie@huawei.com
parent ad1367f8

drivers/gpu/drm/panfrost/panfrost_gpu.c

+2 −2
Original line number Diff line number Diff line
@@ -390,8 +390,8 @@ int panfrost_gpu_init(struct panfrost_device *pfdev) 
	dma_set_max_seg_size(pfdev->dev, UINT_MAX);



	irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "gpu");

	if (irq <= 0)

		return -ENODEV;

	if (irq < 0)

		return irq;



	err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,

			       IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);

drivers/gpu/drm/panfrost/panfrost_job.c

+2 −2
Original line number Diff line number Diff line
@@ -810,8 +810,8 @@ int panfrost_job_init(struct panfrost_device *pfdev) 
	spin_lock_init(&js->job_lock);



	js->irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "job");

	if (js->irq <= 0)

		return -ENODEV;

	if (js->irq < 0)

		return js->irq;



	ret = devm_request_threaded_irq(pfdev->dev, js->irq,

					panfrost_job_irq_handler,

drivers/gpu/drm/panfrost/panfrost_mmu.c

+2 −2
Original line number Diff line number Diff line
@@ -755,8 +755,8 @@ int panfrost_mmu_init(struct panfrost_device *pfdev) 
	int err, irq;



	irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "mmu");

	if (irq <= 0)

		return -ENODEV;

	if (irq < 0)

		return irq;



	err = devm_request_threaded_irq(pfdev->dev, irq,

					panfrost_mmu_irq_handler,