Commit d67e8b38 authored Aug 30, 2016 by Baoyou Xie Committed by Martin K. Petersen Aug 31, 2016

scsi: move function declarations to scsi_priv.h

We get 2 warnings about global functions without a declaration in the
scsi driver when building with W=1:

drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for 'scsi_requeue_run_queue' [-Wmissing-prototypes]
drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype for 'scsi_evt_thread' [-Wmissing-prototypes]

In fact, both functions are declared in drivers/scsi/scsi_scan.c but
need to move them into scsi_priv.h.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ee6a8773

drivers/scsi/scsi_priv.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -85,12 +85,14 @@ extern void scsi_device_unbusy(struct scsi_device *sdev);
		extern void scsi_queue_insert(struct scsi_cmnd *cmd, int reason);
		extern void scsi_io_completion(struct scsi_cmnd *, unsigned int);
		extern void scsi_run_host_queues(struct Scsi_Host *shost);
		extern void scsi_requeue_run_queue(struct work_struct *work);
		extern struct request_queue scsi_alloc_queue(struct scsi_device sdev);
		extern struct request_queue scsi_mq_alloc_queue(struct scsi_device sdev);
		extern int scsi_mq_setup_tags(struct Scsi_Host *shost);
		extern void scsi_mq_destroy_tags(struct Scsi_Host *shost);
		extern int scsi_init_queue(void);
		extern void scsi_exit_queue(void);
		extern void scsi_evt_thread(struct work_struct *work);
		struct request_queue;
		struct request;
		extern struct kmem_cache *scsi_sdb_cache;

drivers/scsi/scsi_scan.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -217,8 +217,6 @@ static struct scsi_device scsi_alloc_sdev(struct scsi_target starget,
		struct scsi_device *sdev;
		int display_failure_msg = 1, ret;
		struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
		extern void scsi_evt_thread(struct work_struct *work);
		extern void scsi_requeue_run_queue(struct work_struct *work);

		sdev = kzalloc(sizeof(*sdev) + shost->transportt->device_size,
		GFP_ATOMIC);