Commit d6220554 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron
Browse files

iio: dac: ad5380: Make ad5380_remove() return void 



Up to now ad5380_remove() returns zero unconditionally. Make it return
void instead which makes it easier to see in the callers that there is
no error to handle.

Also the return value of i2c and spi remove callbacks is ignored anyway.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarAlexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/20211013203223.2694577-8-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 523742f2

drivers/iio/dac/ad5380.c

+8 −7
Original line number Diff line number Diff line
@@ -444,7 +444,7 @@ static int ad5380_probe(struct device *dev, struct regmap *regmap, 
	return ret;

}



static int ad5380_remove(struct device *dev)

static void ad5380_remove(struct device *dev)

{

	struct iio_dev *indio_dev = dev_get_drvdata(dev);

	struct ad5380_state *st = iio_priv(indio_dev);
@@ -453,13 +453,10 @@ static int ad5380_remove(struct device *dev) 


	kfree(indio_dev->channels);



	if (!IS_ERR(st->vref_reg)) {

	if (!IS_ERR(st->vref_reg))

		regulator_disable(st->vref_reg);

}



	return 0;

}



static bool ad5380_reg_false(struct device *dev, unsigned int reg)

{

	return false;
@@ -493,7 +490,9 @@ static int ad5380_spi_probe(struct spi_device *spi) 


static int ad5380_spi_remove(struct spi_device *spi)

{

	return ad5380_remove(&spi->dev);

	ad5380_remove(&spi->dev);



	return 0;

}



static const struct spi_device_id ad5380_spi_ids[] = {
@@ -566,7 +565,9 @@ static int ad5380_i2c_probe(struct i2c_client *i2c, 


static int ad5380_i2c_remove(struct i2c_client *i2c)

{

	return ad5380_remove(&i2c->dev);

	ad5380_remove(&i2c->dev);



	return 0;

}



static const struct i2c_device_id ad5380_i2c_ids[] = {