Commit d59e3c24 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: c6xdigio: remove unnecessary c6xdigio_pwmo_insn_read() 



The pwm subdevice in this driver sets the subdev_flags to SDF_WRITEABLE
so the s->insn_read callback is not needed. Since this callback simply
outputs a printk(KERN_DEBUG ... message jsut remove it.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c4815b3d

drivers/staging/comedi/drivers/c6xdigio.c

+0 −9
Original line number Diff line number Diff line
@@ -322,14 +322,6 @@ static void C6X_encResetAll(unsigned long baseAddr) 
	}

}



static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,

				   struct comedi_subdevice *s,

				   struct comedi_insn *insn, unsigned int *data)

{

	printk(KERN_DEBUG "c6xdigio_pwmo_insn_read %x\n", insn->n);

	return insn->n;

}



static int c6xdigio_pwmo_insn_write(struct comedi_device *dev,

				    struct comedi_subdevice *s,

				    struct comedi_insn *insn,
@@ -426,7 +418,6 @@ static int c6xdigio_attach(struct comedi_device *dev, 
	s->subdev_flags = SDF_WRITEABLE;

	s->n_chan = 2;

	/*      s->trig[0] = c6xdigio_pwmo; */

	s->insn_read = c6xdigio_pwmo_insn_read;

	s->insn_write = c6xdigio_pwmo_insn_write;

	s->maxdata = 500;

	s->range_table = &range_bipolar10;	/*  A suitable lie */