Commit d47f9775 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/cobalt-lcd: Initialize fb_ops to fbdev I/O-memory helpers 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-11-tzimmermann@suse.de
parent 0296ddfe

drivers/video/fbdev/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -1752,6 +1752,7 @@ config FB_GOLDFISH 
config FB_COBALT

	tristate "Cobalt server LCD frame buffer support"

	depends on FB && MIPS_COBALT

	select FB_IOMEM_HELPERS



config FB_SH7760

	bool "SH7760/SH7763/SH7720/SH7721 LCDC support"

drivers/video/fbdev/cobalt_lcdfb.c

+2 −0
Original line number Diff line number Diff line
@@ -280,7 +280,9 @@ static const struct fb_ops cobalt_lcd_fbops = { 
	.fb_read	= cobalt_lcdfb_read,

	.fb_write	= cobalt_lcdfb_write,

	.fb_blank	= cobalt_lcdfb_blank,

	__FB_DEFAULT_IOMEM_OPS_DRAW,

	.fb_cursor	= cobalt_lcdfb_cursor,

	__FB_DEFAULT_IOMEM_OPS_MMAP,

};



static int cobalt_lcdfb_probe(struct platform_device *dev)